Fixes #8 Added the ability to optionally specify a pylintrc file.

leinardi / pylint-pycharm

A plugin providing both real-time and on-demand scanning of Python files with PyLint from within PyCharm/IDEA.

Apache License 2.0

200 stars 36 forks source link

Fixes #8 Added the ability to optionally specify a pylintrc file. #9

Closed switchtrue closed 6 years ago

switchtrue commented 6 years ago

First time contributor checklist

[x] I have read how to contribute to this project
[x] I have read the code of conduct to this project

Contributor checklist

[x] I am using the provided codeStyleConfig.xml
[x] I have tested my contribution on these versions of PyCharm/IDEA:
- PyCharm Community 2018.2.2
- IntelliJ IDEA 2018.2.1
[x] My contribution is fully baked and ready to be merged as is
[x] I ensure that all the open issues my contribution fixes are mentioned in the commit message of my first commit using the Fixes #1234 syntax

Description

Type of Changes

	Type
✓	:sparkles: New feature

Related Issue

omry commented 6 years ago

does this support project relative pylintrc?

leinardi commented 6 years ago

Hi @switchtrue, thank you for the PR! It looks good, let me know if you want to take care yourself of the comment about the empty of if I can merge it and change it later.

does this support project relative pylintrc?

@omry it should work also with project relative paths if you manually enter a relative path (the browse feature it will always return an absolute path):

switchtrue commented 6 years ago

Hi @leinardi. Thanks for reviewing this so quickly.

I've just pushed changes to this PR to explicitly handle project-relative paths (cc @omry), improve error handling if the pylintrc file doesn't exist and to address your isEmpty comment.

leinardi commented 6 years ago

I merged a PR from yesterday and now there are 2 conflicts: if you want me to solve them or need help let me know (inside the PylintBundle.properties I just removed the leftover dialogue to configure the inspection and added a new method inside the PylintRunner.

switchtrue commented 6 years ago

Changes from master have now been merged and conflicts resolved. The isModified stuff is fixed. I've also bumped the version to 0.10.0.

leinardi commented 6 years ago

Thanks, I will merge it but I will revert the version to 0.9.0 because that is the next soon to be published version.

omry commented 6 years ago

awesome, looking forward to re-enable pylint in my project!