fix: wait properly for postgres exit

leinelissen / embedded-postgres

🐘 A Node package that allows you to spawn a Postgresql cluster programatically.

MIT License

53 stars 10 forks source link

fix: wait properly for postgres exit #10

Closed iki closed 8 months ago

iki commented 10 months ago

Issue:

Error: EBUSY: resource busy or locked, rmdir '...' in stop() method, when the process exit hook was called, but the directory is still locked
- Observed on Windows 11 23H2 22635.2771 x64, on each run

Solution:

Wait waitTimeout after termination
Limit SIGINT termination with exitTimeout
Fallback to SIGKILL termination with killTimeout
Remove data directory also in initialise() if persistent is false

leinelissen commented 8 months ago

Hey there, this issue was mainly due to the fact that on Windows, NodeJS does not properly propagate signals as it would on POSIX systems. In the latest version (beta.11), there is now a separate shutdown procedure for Windows that implements other methods. Would love to hear from you whether that solves your problems!