Black Theme Support

leinelissen / jellyfin-audio-player

🎵 A gorgeous Jellyfin audio streaming app for iOS and Android

https://fintunes.app

MIT License

657 stars 26 forks source link

Black Theme Support #202

Open gjhuerte opened 2 months ago

gjhuerte commented 2 months ago

Changes

Added black theme support
Make navigation bar and gesture bar follow the theme
Fixed light theme not showing media controls on android
Create functions for each color (to separate color retrieving logic from the styles)

Please do note of the ff

I've also added another package to make gesture bar color easily changeable in android.
Commented out the x button in player. Seems it looks good without the x button. (see the screenshots attached) I can remove the comment if this is not approved
Only added black theme lang in english translations (I am unfamiliar with other languages aside from english)

Preview

Player

Screenshot 2024-02-24 at 11 16 19 AM

Album

Screenshot 2024-02-24 at 11 19 22 AM

Screenshot_1708737784 Screenshot_1708737764

Look on Light Mode

Screenshot_1708737775

Look on Dark Mode

Screenshot_1708737770

leinelissen commented 2 months ago

Hey @gjhuerte, thanks for the contribution! I see you've gotten quite far with the implementation, and I'd like to take a closer look at it. Before doing so, I'd like to check in on the design rationale for this. Would you prefer a black theme because of contrast reasons, or because of aesthetics? I'm asking because extended theming adds a maintenance and testing burden to the app, and I'd like to keep things simple when I can.

gjhuerte commented 2 months ago

Hi @leinelissen, I implemented black theme in the app as an alternative to the dark mode. Many apps I've used on android support dark mode (or material) and a toggle for AMOLED/OLED which turns the dark into black. On those apps, I do toggle it to AMOLED/OLED. Upon code checking, I noticed that you have support for the contrast and instead of adding toggle for AMOLED/OLED, I opted to add another theme - black as an alternative to the dark and light themes.

leinelissen commented 2 months ago

Ah right, so it's mostly to do with making the background pure black on the dark theme. Would it be an option to make this into a toggle rather than a separate theme? I am not necessarily against supporting extra themes, but this breaks following the OS's dark mode setting as it changes during the day.