leirdas / pe

0 stars 0 forks source link

Able to edit a student's email to one that already exist #8

Open leirdas opened 1 year ago

leirdas commented 1 year ago

Steps to reproduce:

Enter command: edit A0272758C e/alexyeoh@example.com

Expected: Student email does not change as there is already another student with such an email

Actual: Student email changes to a duplicate email

image.png

nus-se-script commented 1 year ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Different Students are allowed to have the same email

Screenshot 2022-11-11 at 4.31.45 PM.png

Different students are allowed to have the same email. This does not make sense as emails are normally tagged to a unique user.


[original: nus-cs2103-AY2223S1/pe-interim#1963] [original labels: type.FunctionalityBug severity.Low]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

While this might be true, the rationale behind this relaxed constraint is that the emails are not necessarily their personal email or school email, so there can be a case where siblings can use the same email for incoming messages.

Thanks for pointing this out!

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]