search

leits / MeetingBar

🇺🇦 Your meetings at your fingertips in the macOS menu bar
https://meetingbar.app
Apache License 2.0
4.42k stars 191 forks source link

Bug: Dimmed text color in Dark theme does not match rest of bar #314

Closed Sergio-Mira closed 2 years ago

Sergio-Mira commented 3 years ago

App version Current version (3.6.0)

Describe the bug When the screen is not active all the bar icons and text are dimmed. However, the dimmed color of text in Meeting Bar is less readable and does not match the rest.

To Reproduce Steps to reproduce the behavior:

  1. Setup 2 screens
  2. Set Dark theme in MacOS
  3. Click in one of the monitors EXPECTED: Dimmed text color in the other monitor matches the rest of the bar

Screenshots If applicable, add screenshots to help explain your problem. Screenshot 2021-08-17 at 09 40 52

Desktop:

(Thanks for this amazing app btw, it has improved my productivity quite a lot! ❤️ )

Sergio-Mira commented 3 years ago

Color seems to be #232545 but I couldn't find it anywhere in the source.

jgoldhammer commented 3 years ago

Thanks Sergio. I can confirm this problem. I will investigate the root cause of this color UX issue.

jamtur01 commented 2 years ago

Don't think/not sure if this is related but the text is very stark white (4.0.3) and quite hard to read. I can't find an option to change it. I can open another issue if it's unrelated.

Screen Shot 2022-04-22 at 1 26 40 PM
jgoldhammer commented 2 years ago

Yes, I have changed it to white. Maybe we need a different solution for light and dark mode?

jamtur01 commented 2 years ago

I think so - the white looks great in dark mode:

Screen Shot 2022-04-22 at 1 30 15 PM
leits commented 2 years ago

Fixed in 4.0.

jamtur01 commented 2 years ago

@leits Should I open a new issue for the dual colors for dark/light mode?

jamtur01 commented 2 years ago

Ah nm - spotted 9b85e8bc541b405742c211325d5bfa2ac679a0e8

Sergio-Mira commented 2 years ago

This is happening again in the latest version 4.0.5 Screenshot 2022-07-06 at 12 48 35

Sergio-Mira commented 2 years ago

The fix looks to have been somehow reverted: https://github.com/leits/MeetingBar/pull/436/files https://github.com/leits/MeetingBar/blame/master/MeetingBar/StatusBarItemController.swift#L238

GitHub
Fix #354 make text visible for non focused screens by jgoldhammer · Pull Request #436 · leits/MeetingBar
Status READY Description previously the text of the statusbar item was only readable on focused screens by setting the text to white (instead of lightgray) the text is also visible on non focused ...
GitHub
MeetingBar/MeetingBar/StatusBarItemController.swift at master · leits/MeetingBar
🇺🇦 Your next meeting always before your eyes in the macOS menu bar - MeetingBar/MeetingBar/StatusBarItemController.swift at master · leits/MeetingBar