search

leits / MeetingBar

🇺🇦 Your meetings at your fingertips in the macOS menu bar
https://meetingbar.app
Apache License 2.0
4.44k stars 192 forks source link

Bug: Consistent "Ouch! Can't join the ... meeting - Link not found, or your meeting service is not yet supported" #462

Closed vramdal closed 1 year ago

vramdal commented 2 years ago

App version 4.0.5

Installation source Downloaded from https://github.com/leits/MeetingBar/releases/tag/v4.0.5

Describe the bug Consistently getting "Ouch! Can't join the ... meeting - Link not found, or your meeting service is not yet supported" This is happening on meeting events with links to Google Meet, Whereby and Teams (at least).

To Reproduce Steps to reproduce the behavior:

  1. Create a meeting in Calendar.app, link to a Google Meeting (e.g. https://meet.google.com/ygu-nscz-udy)
  2. Wait a minute for the meeting to appear in MeetingBar
  3. Click on the MeetingBar menu bar item
  4. Click on the Google Meet meeting

Expected behavior A web browser opens with the URL of the Google Meet meeting

Actual behaviour A notification saying "Ouch! Can't join the ... meeting - Link not found, or your meeting service is not yet supported". No web browser opens.

Desktop (please complete the following information):

jubr commented 1 year ago

+1 on this. Very happy (relatively new) MeetingBar user! Same error seems to be given when no link is in the meeting. So this also happens on the time blocks I put in my agenda to prevent other people of booking meetings during that time. Hope this one is easy to fix 🤞

leits commented 1 year ago

Thanks for the report, @vramdal! Can you try the latest version?

leits commented 1 year ago

Hi @jubr, If you click on an event without a link, you will receive this notification. It's by design behavior and it literally says that there is no link to any supported service. 😅

jubr commented 1 year ago

@leits I think I figured out why it was showing up without me clicking: it's the Automatic Join feature combined with not having a meeting link (or unsupported url format).

Would it perhaps be possible to not show the Ouch! error if there is no meeting link?

PS. Apologies for hijacking this bugreport conversation 😇

leits commented 1 year ago

@jubr No problem 👍 Glad to see you found a reason. Yeah, it makes sense. Also, there are feature requests to skip maybe calls (#489) and declined.

jubr commented 1 year ago

Hmm.. looks like you already check .meetingLink for nil in https://github.com/leits/MeetingBar/blob/4e74e096e701469976245b388d0cf23b8cb15d10/MeetingBar/ActionsOnEventStart.swift#L69-L71

Could it be that the value for .meetingLink is unexpectedly Truthy here?

jubr commented 1 year ago

I assumed it would auto-update and that I automagically would have the latest version. That much trust I have in MeetingBar ;) I just updated to v4.1.0 - noticed the bugfix in the changelog. Tnx!

leits commented 1 year ago

Since no one else has reported the original issue, I will close this ticket. Feel free @@vramdal to reopen the issue again.