search

leits / MeetingBar

🇺🇦 Your meetings at your fingertips in the macOS menu bar
https://meetingbar.app
Apache License 2.0
4.44k stars 192 forks source link

Added support for optional values in meet links #470

Closed quoimec closed 2 years ago

quoimec commented 2 years ago

Status

IN DEVELOPMENT

Description

Some google meet links appear to have some optional URL components that have no effect on the destination but that are missed by MeetingBar's regex pattern matching.

A normal URL: https://meet.google.com/mog-suqd-enn A newly supported URL: https://meet.google.com/_meet/mog-suqd-enn

Both are valid and both remain supported but this PR allows meeting bar to recognise the second version.

Checklist

Steps to Test or Reproduce

Add a calendar with the optional URL parameter listed above.

quoimec commented 2 years ago

Hello, code-wise, this PR is ready to go, I just haven't added it to the changelog yet as I am a bit confused as to what I should do here as there are multiple versions. The project is at version 4.0.5, the changelog view is at 4.0.0 and the CHANGELOG.md is at 3.11.0. Happy to clean these up but would appreciate some direction for what I should do here. Should I create a new version in all three at 4.0.6?

leits commented 2 years ago

Thanks, @quoimec! I'll update the changelog myself 👍