Bug: Dimmed text color in Dark theme does not match rest of bar

leits / MeetingBar

🇺🇦 Your meetings at your fingertips in the macOS menu bar

https://meetingbar.app

Apache License 2.0

4.44k stars 192 forks source link

Bug: Dimmed text color in Dark theme does not match rest of bar #474

Closed Sergio-Mira closed 1 year ago

Sergio-Mira commented 2 years ago

App version Current version (4.0.5)

Describe the bug When the screen is not active all the bar icons and text are dimmed. However, the dimmed color of text in Meeting Bar is less readable and does not match the rest.

It was fixed in a release (https://github.com/leits/MeetingBar/issues/314) but it has since been reverted it seems: https://github.com/leits/MeetingBar/pull/436/files https://github.com/leits/MeetingBar/blame/master/MeetingBar/StatusBarItemController.swift#L238

To Reproduce Steps to reproduce the behavior:

Setup 2 screens
Set Dark theme in MacOS
Click in one of the monitors EXPECTED: Dimmed text color in the other monitor matches the rest of the bar

Screenshots If applicable, add screenshots to help explain your problem. Screenshot 2021-08-17 at 09 40 52

Desktop:

macOS version: 12.4

leits commented 1 year ago

Hi @Sergio-Mira, Can you check the latest version?

Can't reproduce this issue anymore. So I assume it was fixed in one of the last releases. I'll close the issue but feel free to reopen it.

Sergio-Mira commented 1 year ago

Its still happening unfortunately (v4.1.0), and I'm not able to re-open this issue. Will I open a new one? Thanks!

leits commented 1 year ago

Can I ask you to try again with the latest 4.2?

Sergio-Mira commented 1 year ago

Still happening with 4.2: Screenshot 2022-10-27 at 16 58 24

Sergio-Mira commented 1 year ago

It was fixed in a previous release but I think the change was removed as it might be breaking something else? https://github.com/leits/MeetingBar/commit/9b85e8bc541b405742c211325d5bfa2ac679a0e8

leits commented 1 year ago

Damn, thanks for pointing again, I'll dig into this issue.

leits commented 1 year ago

The removal in https://github.com/leits/MeetingBar/commit/9b85e8bc541b405742c211325d5bfa2ac679a0e8 is the fix? Because this removal wasn't reverted.

Sergio-Mira commented 1 year ago

That line to set it to white seems to be the fix I think and it then got removed probably because it caused some other issue (by the looks of the commit message)

leits commented 1 year ago

Can't reproduce it :(

Are you using "show under title" option for the time appereance?

leits commented 1 year ago

Hardcoding styles[NSAttributedString.Key.foregroundColor] = NSColor.white prevents Apple from changing the appearance of the text based on the background. So white text will always be white with this setting, even when all other icons will become dark to contrast with the background.

Right now, the text color is changing only by Apple, and no matter how hard I try to reproduce this issue text always has the correct color. Are you sure you use the latest version?

The only exception is the old logic for "show under title" option for the time appearance that is available only for macOS Catalina.

Sergio-Mira commented 1 year ago

These are my appearance options in the app: Screenshot 2022-10-28 at 14 37 03

MacOS version is 12.6.1 (21G217) - Monterrey

Sergio-Mira commented 1 year ago

It could have been that the defaults of the app were newer than the OS. It looks like the date time now has a similar (too dark imo) text when its not the active screen. Cosing this issue, thanks!