search

leits / MeetingBar

🇺🇦 Your meetings at your fingertips in the macOS menu bar
https://meetingbar.app
Apache License 2.0
4.43k stars 191 forks source link

Fix notification warning from overlapping with notification settings #511

Closed marcusziade closed 1 year ago

marcusziade commented 1 year ago

close #505

Status

READY

Description

The warning view was overlapping the actual settings. This was a simple fix by embedding the views inside a VStack.

OLD

CleanShot 2022-09-23 at 09 30 39@2x

FIXED

CleanShot 2022-09-23 at 10 13 19@2x

Checklist

m-graf commented 1 year ago

Nice one :)

leits commented 1 year ago

Hi @marcusziade! Thanks for trying to fix it, but this bug is already fixed here https://github.com/leits/MeetingBar/commit/49101e03f46fbaf199a478a9de5cbc4f3af36b7a

marcusziade commented 1 year ago

@leits I don't understand why you didn't merge my code that's been ready for 2 weeks.

Also, why did you use an HStack?

leits commented 1 year ago

Sorry, @marcusziade. I fixed it in July and even published the update in AppStore, but I forgot to update it here.