leits / MeetingBar

πŸ‡ΊπŸ‡¦ Your meetings at your fingertips in the macOS menu bar
https://meetingbar.app
Apache License 2.0
4.43k stars 191 forks source link

Bug: doesn't find meeting link in notes #524

Closed j-ro closed 1 year ago

j-ro commented 1 year ago

App version

4.0.6

Installation source

manual

App Version

Calendars provider (selected in app)

Describe the bug

I have zoom links in the notes of a calendar item (and it shows as in the notes in MeetingBar when I view details) but when I use the shortcode to open the zoom link, MeetingBar says it can't find a link to open.

To Reproduce Steps to reproduce the behavior:

  1. Go to a meeting with a zoom link in the notes
  2. Use the shortcut to open the zoom link
  3. Get an error saying no zoom link is found

Expected behavior Zoom link opens in the browser

Screenshots Meeting has zoom link in notes (cut off to preserve privacy but you get the idea):

Screen Shot 2022-10-19 at 9 15 51 AM

But shortcut doesn't work:

Screen Shot 2022-10-19 at 9 15 27 AM

Desktop (please complete the following information):

leits commented 1 year ago

Thanks for the report, @j-ro! Can you check your link in regex101.com with this regex?

https?:\/\/(?:[a-zA-Z0-9-.]+)?zoom.(?:us|com.cn)\/(?:j|my|w)\/[-a-zA-Z0-9()@:%_\+.~#?&=\/]*

Or change a few symbols with similar ones and share the link with me?

j-ro commented 1 year ago

No match! Here's a link (the original link has 9 numbers at the end, but I changed them here): https://zoom.us/s/123456789

Adding as s option to the match for after zoom.com makes it work though, so maybe that's the answer here?

https?:\/\/(?:[a-zA-Z0-9-.]+)?zoom.(?:us|com.cn)\/(?:j|my|w|s)\/[-a-zA-Z0-9()@:%_+.~#?&=\/]*

Zoom Video
Join our Cloud HD Video Meeting
Zoom is the leader in modern enterprise video communications, with an easy, reliable cloud platform for video and audio conferencing, chat, and webinars across mobile, desktop, and room systems. Zoom Rooms is the original software-based conference room solution used around the world in board, conference, huddle, and training rooms, as well as executive offices and classrooms. Founded in 2011, Zoom helps businesses and organizations bring their teams together in a frictionless environment to get more done. Zoom is a publicly traded company headquartered in San Jose, CA.
leits commented 1 year ago

Yeah, that's the answer! I'll change it to

https?:\/\/(?:[a-zA-Z0-9-.]+)?zoom.(?:us|com.cn)\/(?:my|[a-z])\/[-a-zA-Z0-9()@:%_\+.~#?&=\/]*

so any new single letter will be supported in the future. It seems that they ran out of numbers in the spaces of the previous letters.

j-ro commented 1 year ago

Nice, makes sense! Does the app do automatic updates?

leits commented 1 year ago

Yes, after the release, but only for homebrew and AppStore installation πŸ˜…

j-ro commented 1 year ago

ok cool, I think I'm appstore, will await the update!