leits / MeetingBar

🇺🇦 Your meetings at your fingertips in the macOS menu bar
https://meetingbar.app
Apache License 2.0
4.43k stars 191 forks source link

Bug: Regex did not catch meeting #530

Closed whazlewo closed 1 year ago

whazlewo commented 1 year ago

App version 4.1

Installation source

App Version

Calendars provider (selected in app)

Describe the bug A clear and concise description of what the bug is. I have this regex defined to filter out all "happy hours" and "office hours" /.*[office|happy] hour[s]?.*/ig

But I got auto dialed into a meeting titled: "Visual+UI Office Hours"

To Reproduce Steps to reproduce the behavior:

  1. Go to Preferences
  2. Select Advanced Tab
  3. Select "Add regex" under "Custom regexes to filter out meetings"
  4. Add meeting titled "Visual+UI Office Hours" to calendar
  5. Watch for auto-dial in

Expected behavior A clear and concise description of what you expected to happen. I was expecting to A) Not see the "Visual+UI Office Hours" meeting in my system tray B) Not be auto dialed in.

Screenshots

Screen Shot 2022-10-26 at 10 23 00 AM

Desktop (please complete the following information):

I'd love some way to see a list of the events that my regexes are going to match as a way to confrm

I'd also love a feature that lets me just say "Don't auto dial these meetings" rather than filtering out all meetings (ie. i'd like the option to have it still show up in my system tray, just not auto dial that meeting)

While I'm just throwing feature requests out, I'd REALLY like the ablility to say "don't auto-dial tentative (maybe) meetings. (ie. only auto dial meetings marked "Accept").

leits commented 1 year ago

Hi @whazlewo, Thanks for the report! The regex modifier won't work in this way with Swift. Also, square brackets don't work the way you think. [office] will match "office" as well as "off" or "ceo".

So the correct regex for your case will be this one:

(?i).*(office|happy) (hour)s?.*
whazlewo commented 1 year ago

Today I learned that a Regex is not the same in all languages :-) and read up on brackets.

Thank you @leits