leits / MeetingBar

🇺🇦 Your meetings at your fingertips in the macOS menu bar
https://meetingbar.app
Apache License 2.0
4.48k stars 197 forks source link

Fix calendar email for meeting link #538

Closed mumer92 closed 1 year ago

mumer92 commented 1 year ago

Status

READY

Description

After updating Macbook Pro M1 to macOS 13.0 (22A380), tapping on calendar event was opening the meeting url in the browser but email account was not associated with the link, thus Google Meet was not opening on right email. I have tried uninstalling/reinstalling from appstore, brew and building from source, but link was not proper. After debugging code, I noticed that the function getGmailAccount was returning nil, (there was already a note there that this is bit hacky).

After looking further in the code, I saw that email was empty in MBCalendar but email was present in attendee, so I have modified fetchAllCalendars function a little bit to get email of the current user from the list of attendees. I have tested this changed and it seems to be working perfectly, i.e. email is being properly appending to the url and. Google Meet link is being opened with the right email of which the event is associated to.

Checklist

Steps to Test or Reproduce

mumer92 commented 1 year ago

@leits any update on this?

pif commented 1 year ago

@leits any chance this would get to a new release soon?

leits commented 1 year ago

Thanks for the request, @mumer92! I used your changes to fix the email in a slightly different place. In case, when the calendar is connected, there are no events in it for the next day.