Add "Run Apple Script on keyboard shortcut" feature

leits / MeetingBar

🇺🇦 Your meetings at your fingertips in the macOS menu bar

https://meetingbar.app

Apache License 2.0

4.36k stars 188 forks source link

Add "Run Apple Script on keyboard shortcut" feature #575

Closed neilkimmett closed 1 year ago

neilkimmett commented 1 year ago

Status

READY

Description

Closes #573. Adds support to run an AppleScript when you press a keyboard shortcut.

Wasn't sure whether to add a "test" button in there too?.
Also not sure how localization works.
Missed the CHANGELOG entry, let me add that now

Checklist

[ ] Localized
[x] Added to changelog:
- [x] Changelog View
- [x] CHANGELOG.md

Steps to Test or Reproduce

Open Preferences > Advanced
Check the "Run AppleScript on keyboard shortcut" checkbox
Choose a keyboard shortcut
Hit "Edit script" and put in a script
???
Profit!

neilkimmett commented 1 year ago

@leits anything else you need from me to help get this merged?

leits commented 1 year ago

Hi @neilkimmett. Sorry for the delay! You can get the same result in a few clicks with the built-in macOS app Shortcuts. Thank you for the request and the implementation but sorry, but I'll close this PR to not inflate the application's functionality.

Share late if you managed to set up Shortcuts!

neilkimmett commented 1 year ago

@leits oh interesting, I didn't know that! How can I get that set up using Shortcuts?

leits commented 1 year ago

Go to Shortcuts, click on "New command" button (+), and search "Run AppleScript" in actions. To assign a keyboard shortcut, open "Shortcut details" tab with (i) icon and use "Add keyboard shortcut" button.

The names of the buttons may be slightly different because I have Ukrainian localization :)

neilkimmett commented 1 year ago

Right, but what I want is to run an AppleScript with the details of my next meeting, which is where MeetingBar comes in.

neilkimmett commented 1 year ago

The use case I personally have is: when I press keyboard shortcut -> MeetingBar pulls out meetingNotes from my next meeting -> AppleScript parses and pulls out zoom meeting id and passcode from meeting notes, then puts them on screen (so I can dial into meeting from a conference room)

leits commented 1 year ago

I get you, @neilkimmett Made a release with the actions of MeetingBar for Shortcuts. There is an action for getting the nearest event details so you can get event notes and pass them to AppleScript. Check it out!

neilkimmett commented 1 year ago

@leits oh nice yeah that should do the job for me. I just updated to 4.4 but for some reason MeetingBar's actions aren't showing up in the Shortcuts app. I'll see if I can figure out why, but if you have any pointers that would be fab. Thanks for all the hard work!