Closed danvk closed 4 years ago
The PR Quality Review check is about adding a console.log
in a test file:
This is done in other test files as well https://github.com/leizongmin/js-xss/blob/b68163f444806cdb65ff64b80b0bc6c43d75d616/typings/xss-tests.ts#L16-L19
continuous-integration/travis-ci/pr
is also broken on master.
Thank you. This change will be included in the next release version.
I just published a new version xss@1.0.8
including this changes. Thanks for your pull request.
Thanks for the quick release, @leizongmin! I merged this update into my project and it works great.
This makes the ES6 version of the example on the homepage work:
Note that this only works if
esModuleInterop
is set totrue
, which is officially recommended (tsc init
produces atsconfig.json
file with it set). You can read more about it here.The existing type tests seemed to be broken before this PR:
After it they are not: