search

leizongmin / js-xss

Sanitize untrusted HTML (to prevent XSS) with a configuration specified by a Whitelist
http://jsxss.com
Other
5.19k stars 630 forks source link

[Discussion] Usage of the term "whitelist" #219

Open JonHX opened 3 years ago

JonHX commented 3 years ago

Firstly thanks to all the contributors for this fantastic module.

Was wondering if the owners were open to removing the usage of "whitelist". My current organization tries to steer away from this terminology/connotation in our codebases. Happy to do the PR myself.

Alternatives for blacklist/whitelist are denylist/allowlist and blocklist/passlist.

Kindest,

Jon

lencioni commented 3 years ago

At Airbnb, we use eslint-plugin-inclusive-language to enforce the use of inclusive language in our codebase, and would also like to be able to use xss without having to disable this rule.

Perhaps allowlist could be added as an alternative without removing whiteList so it would not be a breaking change? Then whiteList could be removed later, whenever the next major version is ready.

@leizongmin what do you think? Would you accept such a pull request?

leizongmin commented 3 years ago

Hi, @lencioni I would be happy to accept such pull request.

thesaltygerman commented 2 years ago

Enforce silly language rules one country care about is not good. No one care about your race or sensitive words. Stop putting rules for other country, culture. We do not care about easy offend United States and UK people. You are not important as you think.

Blacklist Whitelist used forever in computers and do not mean your race problem in United States and UK. You did slaves, not world. Get over yourself.

ThomasRedstone commented 2 years ago

Yeah... A lot of countries have some history of slavery, or worse, as I'm sure you're well aware during World War 2 Germany wasn't good to people of colour and did have slavery (more focused on Russians, but still slavery):

https://www.rbth.com/history/329852-ostarbeiter-soviet-captives-in-germany

So it really does seem that you should be a bit more concerned about this kind of language than you are.

Ultimately this is about what people who are affected by it think, salty people, German or otherwise, don't really get a say.