search

lejacobroy / Tidalrr

Self-hosted Tidal library sync
Apache License 2.0
30 stars 4 forks source link

make port configurable #9

Closed ramonskie closed 6 months ago

ramonskie commented 6 months ago

as port 3001 is used by other servers it would be nice to make this configurable.

ramonskie commented 6 months ago

it would probably look like this port = os.environ.get("WEB_PORT", "3001")

app.run(host="0.0.0.0", port=port, debug=debug)

i tried to build it localy but i stumbled upon the following error

➜  Tidalrr git:(master) ✗ python3 app.py
Starting tidalrr app
Process Process-1:
Traceback (most recent call last):
  File "/home/ramonskie/.pyenv/versions/3.8.5/lib/python3.8/multiprocessing/process.py", line 315, in _bootstrap
    self.run()
  File "/home/ramonskie/.pyenv/versions/3.8.5/lib/python3.8/multiprocessing/process.py", line 108, in run
    self._target(*self._args, **self._kwargs)
  File "/home/ramonskie/workspace/Tidalrr/tidalrr/webserver/__init__.py", line 169, in webServer
    migration()
  File "/home/ramonskie/workspace/Tidalrr/tidalrr/database/__init__.py", line 51, in migration
    conn.execute("ALTER TABLE tidal_artists \
sqlite3.OperationalError: no such column: "queued"
Scans are scheduled
Downloads are scheduled

and i currently don't have the time to debug it. otherwise i would have made a PR :)

EDIT: error above was fixed with https://github.com/lejacobroy/Tidalrr/pull/8

ramonskie commented 6 months ago

created a pr #10

guycobb2 commented 6 months ago

are you not using docker? if so it's easy enough to set a port to redirect. if using something else that doesn't allow that though, then i see how that could be an annoyance.

ramonskie commented 6 months ago

yes i'm using docker but its docker on synology. so there are some caveats with the networking. i tried to set

ports:
- 3101-3001

but it never reaches the container. so for these scenarios it would be nice to be able to configure the port. its also pretty simple as you can see in the pr

EDIT: i thought it was synology but now that im checking the proper logs. the webserver is actually never started due to the issue stated in #8

lejacobroy commented 6 months ago

The recommended way to change ports is using docker-compose, yes.

ramonskie commented 6 months ago

@lejacobroy i noticed you merged #8 but the docker container has not been updated yet. so the error still persists when using the latest docker image.

lejacobroy commented 6 months ago

Sorry about that, my build server was down for a few days and I completely forgot to push a new image.

lejacobroy commented 6 months ago

Merged with commit https://github.com/lejacobroy/Tidalrr/commit/2cb5d99e8437b8190ab0db812a1ab2ddc649e8e4 Thank you! 👍