search

lejeffe / MonsterHP

Show the current monster hp based on either percentage remaining or current hp
BSD 2-Clause "Simplified" License
0 stars 10 forks source link

add 1 decimal place to formatting #12

Closed thejdubs closed 2 years ago

thejdubs commented 2 years ago

closes #11 without option version

thejdubs commented 2 years ago

wrote 2 commits, one with config option, one as just the default let me know which one you prefer

lejeffe commented 2 years ago

Before i add it, have you tested it yourself.

lejeffe commented 2 years ago

I would prefer to let the user choose to add the decimal or not, but have this on by default. Can you make this happen? Limited on time at the moment.

thejdubs commented 2 years ago

hmm after some more testing, I don't think it actually adds too much value. Since we only get the hp bar length value to determine the percentage most are inaccurate (comparing with the in game which uses true value). Also the increased precision will only even be really helpful with larger hp bars. Think i might scrap it. Let me know what you think.

lejeffe commented 2 years ago

It could prove use full within ToA as these npc's have more detailed hp bars. But this would need further testing to actually know if it adds anything

thejdubs commented 2 years ago

yea thats where i was doing my testing. akkha's health bar doesnt provide any more precision zebak's provides a bit more, but the numbers arent fully accurate when comparing to the in game percents