Edition only if ACLs permit it + filename customization + namespace customization

lejmr / dokuwiki-plugin-drawio

Draw.io plugin for DokuWiki

https://www.dokuwiki.org/plugin:drawio

GNU General Public License v2.0

25 stars 13 forks source link

Edition only if ACLs permit it + filename customization + namespace customization #19

Closed pekingo44 closed 4 years ago

pekingo44 commented 4 years ago

Hello. I have created a new fork with two evolutions needed for my own business : 1) mode "read-only" if the ACL plugin is activated and if the rule défined for the page don't allow edition. 2) ability to customize the filename or/and the namespace used for the image. It's only in the script.js.

Regards

lejmr commented 4 years ago

can you please answer my questions? The part improving the ACL looks ok by the code, but I will test it before merging.

For the first part where you are customizing file names. I dont like. Unless you have a good explanation why is this needed I wont merge it. You need to buy me for it.

Can you please split this pull-requests into two? The ACL portion I will be happy to merge, but the first one we need to discuss.

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.