search

lejmr / dokuwiki-plugin-drawio

Draw.io plugin for DokuWiki
https://www.dokuwiki.org/plugin:drawio
GNU General Public License v2.0
25 stars 13 forks source link

Add option to manually set zIndex on DrawIO iFrame #28

Closed SoarinFerret closed 4 years ago

SoarinFerret commented 4 years ago

Manually set zIndex on DrawIO iFrame

On the theme I am using, the navbar and sidebar both have higher z-Index values than draw.io. Instead of modifying the theme to fix or simply setting this plugin's iframe to a higher z-index, I added the option to set the z-index in the configuration settings.

I left the default value to still be 999, which is what the plugin sets normally, so default behavior will not change.

Here is a screenshot of the admin configuration page:

image

Please let me know if there is something you would like me to do differently - I am do not traditionally code with either PHP or JavaScript, so I'm sure there is some room for improvement.

Fixes #27

lejmr commented 4 years ago

Sounds like a fantastic improvement. Will check the pr ASAP

lejmr commented 4 years ago

Can you please adjust formatting? Seems the action.php contains all lines changed, but it does not seem you changed everything :-) Thanks

SoarinFerret commented 4 years ago

My bad, looks like my editor converted the line endings from CRLF to just LF, I'll change it back

lejmr commented 4 years ago

Thank you for contribution