Drop Julia 0.4 support, futher enhance performance

lejon / TSne.jl

Julia port of L.J.P. van der Maaten and G.E. Hintons T-SNE visualisation technique.

Other

143 stars 25 forks source link

Drop Julia 0.4 support, futher enhance performance #10

Closed alyst closed 7 years ago

alyst commented 7 years ago

remove Julia 0.4 to Travis CI
add Julia 0.6 to Travis CI
remove Compat 0.9 and BaseTestNext dependencies
fix Julia 0.6 warnings

coveralls commented 7 years ago

Coverage decreased (-0.02%) to 99.275% when pulling 5d4e5c24f2de120b581b90a9cb7267863def5bcd on alyst:julia_0.6 into ace303b65c834027bbe68b556fa9160ef29343c1 on lejon:master.

coveralls commented 7 years ago

Coverage decreased (-0.02%) to 99.275% when pulling 5d4e5c24f2de120b581b90a9cb7267863def5bcd on alyst:julia_0.6 into ace303b65c834027bbe68b556fa9160ef29343c1 on lejon:master.

coveralls commented 7 years ago

Coverage decreased (-0.02%) to 99.275% when pulling 5d4e5c24f2de120b581b90a9cb7267863def5bcd on alyst:julia_0.6 into ace303b65c834027bbe68b556fa9160ef29343c1 on lejon:master.

coveralls commented 7 years ago

Coverage decreased (-0.02%) to 99.275% when pulling 39cd856e8cefd96d6dde18d93010db62ee43c212 on alyst:julia_0.6 into ace303b65c834027bbe68b556fa9160ef29343c1 on lejon:master.

coveralls commented 7 years ago

Coverage decreased (-0.02%) to 99.275% when pulling 39cd856e8cefd96d6dde18d93010db62ee43c212 on alyst:julia_0.6 into ace303b65c834027bbe68b556fa9160ef29343c1 on lejon:master.

coveralls commented 7 years ago

Coverage decreased (-0.02%) to 99.275% when pulling 39cd856e8cefd96d6dde18d93010db62ee43c212 on alyst:julia_0.6 into ace303b65c834027bbe68b556fa9160ef29343c1 on lejon:master.

alyst commented 7 years ago

It turned out that keyword-arg-containing methods have problems with type inference (JuliaLang/julia#9551), so tsne() was severely affected, because both perplexities() and std() contain keyword args. With this (+ the other issues highlighted by profiling) fixed I got dramatic speed-ups (from ~150s to ~30s). Hopefully it would also solve Travis timeouts.

coveralls commented 7 years ago

Coverage remained the same at 99.296% when pulling 4d4dd22c77912c2b6617b38895e2b4a2dd0682f1 on alyst:julia_0.6 into ace303b65c834027bbe68b556fa9160ef29343c1 on lejon:master.

coveralls commented 7 years ago

Coverage remained the same at 99.296% when pulling 68334c6cc523f91ebc92f7df359bbdbf4ffc379f on alyst:julia_0.6 into ace303b65c834027bbe68b556fa9160ef29343c1 on lejon:master.

coveralls commented 7 years ago

Coverage remained the same at 99.296% when pulling ad652515ffaeed55913f0414c55fa18905d61c3f on alyst:julia_0.6 into ace303b65c834027bbe68b556fa9160ef29343c1 on lejon:master.

coveralls commented 7 years ago

Coverage remained the same at 99.296% when pulling ad652515ffaeed55913f0414c55fa18905d61c3f on alyst:julia_0.6 into ace303b65c834027bbe68b556fa9160ef29343c1 on lejon:master.

coveralls commented 7 years ago

Coverage remained the same at 99.296% when pulling ad652515ffaeed55913f0414c55fa18905d61c3f on alyst:julia_0.6 into ace303b65c834027bbe68b556fa9160ef29343c1 on lejon:master.

coveralls commented 7 years ago

Coverage remained the same at 99.296% when pulling 7518b2c0d9496a994c4a2b1d5fde764af30663e4 on alyst:julia_0.6 into ace303b65c834027bbe68b556fa9160ef29343c1 on lejon:master.

coveralls commented 7 years ago

Coverage remained the same at 99.296% when pulling 7518b2c0d9496a994c4a2b1d5fde764af30663e4 on alyst:julia_0.6 into ace303b65c834027bbe68b556fa9160ef29343c1 on lejon:master.

coveralls commented 7 years ago

Coverage remained the same at 99.296% when pulling 7518b2c0d9496a994c4a2b1d5fde764af30663e4 on alyst:julia_0.6 into ace303b65c834027bbe68b556fa9160ef29343c1 on lejon:master.

alyst commented 7 years ago

Don't know why certain tests are 1000x slower on 0.5 than on 0.6 when running from Travis. On my system there's no such difference between the versions.