search

lejon / TSne.jl

Julia port of L.J.P. van der Maaten and G.E. Hintons T-SNE visualisation technique.
Other
143 stars 25 forks source link

Fix pca() #21

Closed alyst closed 6 years ago

alyst commented 6 years ago

It turns out that after #18 pca() was using the top ndims smallest eigenvalues of X'*X. Fix it to use the top ndims largest ones.

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 99.315% when pulling a7e9a0cb577c4fd1e43324c9813f4696293ed0bf on alyst:fix_pca into a88ed686734a8acd9531fd3fd8d41127d7054233 on lejon:master.

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 99.315% when pulling a7e9a0cb577c4fd1e43324c9813f4696293ed0bf on alyst:fix_pca into a88ed686734a8acd9531fd3fd8d41127d7054233 on lejon:master.