search

lejon / TSne.jl

Julia port of L.J.P. van der Maaten and G.E. Hintons T-SNE visualisation technique.
Other
143 stars 25 forks source link

Add project.toml #26

Closed simonschoelly closed 4 years ago

simonschoelly commented 4 years ago

This PR replaces the REQUIRE files with a Project.toml.

In addition:

coveralls commented 4 years ago

Coverage Status

Coverage decreased (-0.7%) to 99.301% when pulling 8bf47e520fd6a60befbf44487fcb10ad41846fb3 on simonschoelly:add-project.toml into a310d395c0bbbd48952a87ebf8eddc54d8639bbf on lejon:master.

lejon commented 4 years ago

Thanks a bunch!

simonschoelly commented 4 years ago

You have closed this without merging?

May I ask if you don't plan to make this package work with the current Julia version? Or are you planning to do in another way?

lejon commented 4 years ago

Really?! That was a mistake then. Admittedly I did it on the phone while traveling so perhaps I mucked up, the intention was certainly to merge it! I’ll have a look!

BR -Leif

On 7 Sep 2020, at 01:09, Simon Schoelly notifications@github.com wrote:

 You have closed this without merging?

May I ask if you don't plan to make this package work with the current Julia version? Or are you planning to do in another way?

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub, or unsubscribe.

lejon commented 4 years ago

Ok, I realise what the problem was, there was a "confirm merge" that I apparently missed in the phone GUI. Thanks again for letting me know! :)

Cheers!

yha commented 3 years ago

The new Project.toml seems to use a different UUID than the one TSne.jl is registered under. Is this UUID change intended? This makes it currently impossible to do ]add TSne#master

simonschoelly commented 3 years ago

No, this was my fault, I did not realize that the project already had a UUID in the general registry. I will fix that.

yha commented 3 years ago

Also, what are the new compat bounds based on? Locally, I see that tests pass with Distances 0.8 (which I'm using because ImageSegmentation still caps the Distances version)

simonschoelly commented 3 years ago

I just added the newest compat bounds. To be honest, I am not really sure what is the best strategy here. Set it to 0.8.0? Then it will be caped to versions < 0.9.0. Or maybe explicitly set it to 0.8.0, 0.9.0?

yha commented 3 years ago

I think adding the newest compat bounds is a reasonable default, if it was tested on these versions. I just thought there might be some more specific reason, because there are bounds only for some of the dependencies, Based on the tests passing on my machine, I will set the Distances bounds to 0.8, 0.9 in a new PR.