search

leka / LekaOS

LekaOS is Leka's firmware based on Mbed OS
https://leka.io
Apache License 2.0
14 stars 7 forks source link

:recycle: (ColorKit): Add const to conversion local variables #1313

Closed ladislas closed 1 year ago

github-actions[bot] commented 1 year ago

:bookmark: Version comparison

Version Same as filename Same as os_version
os 1.3.0+1678380513 ✔️ ✔️
firmware
(bootloader + os)		 1.3.0+1678380513 ✔️ ✔️
github-actions[bot] commented 1 year ago

:chart_with_upwards_trend: Changes Impact Analysis Report

:pushpin: Info

base head
branch develop ladislas/feature/color-kit-add-const
sha c00770c9 9e42bc68
mbed mbed-os@master+fixes+gcc-11-support mbed-os@master+fixes+gcc-11-support
-std -std=c++20 -std=c++20

:robot: Firmware impact analysis

Target Flash Used (base/head) Flash Used Δ Flash Available (base/head) Static RAM (base/head) Static RAM Δ
bootloader 183692 (70%) ø 78452 (29%)
78452 (29%)		 41664 (7%) ø
os 507436 (32%) ø 1057236 (67%)
1057236 (67%)		 95104 (18%) ø
Click to show memory sections ``` | - | Hex | Bytes | KiB | |------------|---------:|----------:|-----:| | Flash | 0x200000 | 2 097 152 | 2048 | | SRAM | 0x80000 | 524 288 | 512 | | Bootloader | 0x40000 | 262 144 | 256 | | Header | 0x1000 | 4 096 | 4 | | OS | 0x17E000 | 1 564 672 | 1528 | | Tail | 0x1000 | 4 096 | 4 | | Scratch | 0x40000 | 262 144 | 256 | ```

:microscope: Detailed impact analysis

Click to show detailed analysis for all targets - :heavy_check_mark: - existing target - :sparkles: - new target - :coffin: - deleted target - :white_check_mark: - files are the same - :x: - files are different | Target | Status | .bin | .map | Total Flash (base/head) | Total Flash Δ | Static RAM (base/head) | Static RAM Δ | |-------|:------:|:------:|:------:|:------:|:------:|:------:|:------:| | LekaOS | :heavy_check_mark: | :white_check_mark: | :white_check_mark: | 507436 (24%) | ø | 95104 (18%) | ø | | bootloader | :heavy_check_mark: | :white_check_mark: | :white_check_mark: | 183692 (8%) | ø | 41664 (7%) | ø | | functional_ut_boost_ut | :heavy_check_mark: | :white_check_mark: | :white_check_mark: | 409276 (19%) | ø | 30608 (5%) | ø | | functional_ut_core_imu | :heavy_check_mark: | :white_check_mark: | :white_check_mark: | 385140 (18%) | ø | 31120 (5%) | ø | | functional_ut_deep_sleep_core_buffered_serial | :heavy_check_mark: | :white_check_mark: | :white_check_mark: | 368332 (17%) | ø | 30560 (5%) | ø | | functional_ut_deep_sleep_core_motor | :heavy_check_mark: | :white_check_mark: | :white_check_mark: | 376140 (17%) | ø | 30632 (5%) | ø | | functional_ut_deep_sleep_core_pwm | :heavy_check_mark: | :white_check_mark: | :white_check_mark: | 378356 (18%) | ø | 30632 (5%) | ø | | functional_ut_deep_sleep_log_kit | :heavy_check_mark: | :white_check_mark: | :white_check_mark: | 365268 (17%) | ø | 30976 (5%) | ø | | functional_ut_deep_sleep_mbed_hal | :heavy_check_mark: | :white_check_mark: | :white_check_mark: | 366712 (17%) | ø | 30560 (5%) | ø | | functional_ut_file_manager | :heavy_check_mark: | :white_check_mark: | :white_check_mark: | 388092 (18%) | ø | 30856 (5%) | ø | | functional_ut_firmware_kit | :heavy_check_mark: | :white_check_mark: | :white_check_mark: | 379116 (18%) | ø | 30848 (5%) | ø | | functional_ut_imu_kit | :heavy_check_mark: | :white_check_mark: | :white_check_mark: | 388896 (18%) | ø | 31296 (5%) | ø | | functional_ut_io_expander | :heavy_check_mark: | :white_check_mark: | :white_check_mark: | 371176 (17%) | ø | 30576 (5%) | ø | | functional_ut_qdac | :heavy_check_mark: | :white_check_mark: | :white_check_mark: | 372344 (17%) | ø | 30576 (5%) | ø | | spike_lk_audio | :heavy_check_mark: | :white_check_mark: | :white_check_mark: | 137724 (6%) | ø | 25168 (4%) | ø | | spike_lk_behavior_kit | :heavy_check_mark: | :white_check_mark: | :white_check_mark: | 198500 (9%) | ø | 58672 (11%) | ø | | spike_lk_ble | :heavy_check_mark: | :white_check_mark: | :white_check_mark: | 237980 (11%) | ø | 39416 (7%) | ø | | spike_lk_bluetooth | :heavy_check_mark: | :white_check_mark: | :white_check_mark: | 92364 (4%) | ø | 22224 (4%) | ø | | spike_lk_cg_animations | :heavy_check_mark: | :white_check_mark: | :white_check_mark: | 153672 (7%) | ø | 57224 (10%) | ø | | spike_lk_color_kit | :heavy_check_mark: | :white_check_mark: | :white_check_mark: | 88544 (4%) | ø | 24376 (4%) | ø | | spike_lk_command_kit | :heavy_check_mark: | :white_check_mark: | :white_check_mark: | 229972 (10%) | ø | 63960 (12%) | ø | | spike_lk_config_kit | :heavy_check_mark: | :white_check_mark: | :white_check_mark: | 139780 (6%) | ø | 25184 (4%) | ø | | spike_lk_coreled | :heavy_check_mark: | :white_check_mark: | :white_check_mark: | 88108 (4%) | ø | 24264 (4%) | ø | | spike_lk_core_touch_sensor | :heavy_check_mark: | :white_check_mark: | :white_check_mark: | 93164 (4%) | ø | 22824 (4%) | ø | | spike_lk_event_queue | :heavy_check_mark: | :white_check_mark: | :white_check_mark: | 84152 (4%) | ø | 22904 (4%) | ø | | spike_lk_file_manager_kit | :heavy_check_mark: | :white_check_mark: | :white_check_mark: | 154560 (7%) | ø | 25520 (4%) | ø | | spike_lk_file_reception | :heavy_check_mark: | :white_check_mark: | :white_check_mark: | 339964 (16%) | ø | 38448 (7%) | ø | | spike_lk_flash_memory | :heavy_check_mark: | :white_check_mark: | :white_check_mark: | 86776 (4%) | ø | 22216 (4%) | ø | | spike_lk_fs | :heavy_check_mark: | :white_check_mark: | :white_check_mark: | 178228 (8%) | ø | 57536 (10%) | ø | | spike_lk_imu_kit | :heavy_check_mark: | :white_check_mark: | :white_check_mark: | 107280 (5%) | ø | 23728 (4%) | ø | | spike_lk_lcd | :heavy_check_mark: | :white_check_mark: | :white_check_mark: | 173500 (8%) | ø | 57520 (10%) | ø | | spike_lk_led_kit | :heavy_check_mark: | :white_check_mark: | :white_check_mark: | 115204 (5%) | ø | 25104 (4%) | ø | | spike_lk_log_kit | :heavy_check_mark: | :white_check_mark: | :white_check_mark: | 84776 (4%) | ø | 23408 (4%) | ø | | spike_lk_motion_kit | :heavy_check_mark: | :white_check_mark: | :white_check_mark: | 117008 (5%) | ø | 25952 (4%) | ø | | spike_lk_motors | :heavy_check_mark: | :white_check_mark: | :white_check_mark: | 86336 (4%) | ø | 22248 (4%) | ø | | spike_lk_qdac | :heavy_check_mark: | :white_check_mark: | :white_check_mark: | 91796 (4%) | ø | 22768 (4%) | ø | | spike_lk_reinforcer | :heavy_check_mark: | :white_check_mark: | :white_check_mark: | 225428 (10%) | ø | 60640 (11%) | ø | | spike_lk_rfid | :heavy_check_mark: | :white_check_mark: | :white_check_mark: | 84216 (4%) | ø | 22184 (4%) | ø | | spike_lk_sensors_battery | :heavy_check_mark: | :white_check_mark: | :white_check_mark: | 87376 (4%) | ø | 23312 (4%) | ø | | spike_lk_sensors_imu_lsm6dsox | :heavy_check_mark: | :white_check_mark: | :white_check_mark: | 98624 (4%) | ø | 23536 (4%) | ø | | spike_lk_sensors_imu_lsm6dsox_fusion_calibration | :heavy_check_mark: | :white_check_mark: | :white_check_mark: | 105064 (5%) | ø | 23104 (4%) | ø | | spike_lk_sensors_light | :heavy_check_mark: | :white_check_mark: | :white_check_mark: | 84072 (4%) | ø | 22216 (4%) | ø | | spike_lk_sensors_microphone | :heavy_check_mark: | :white_check_mark: | :white_check_mark: | 84824 (4%) | ø | 22216 (4%) | ø | | spike_lk_sensors_temperature_humidity | :heavy_check_mark: | :white_check_mark: | :white_check_mark: | 90616 (4%) | ø | 22192 (4%) | ø | | spike_lk_serial_number | :heavy_check_mark: | :white_check_mark: | :white_check_mark: | 145028 (6%) | ø | 25256 (4%) | ø | | spike_lk_ticker_timeout | :heavy_check_mark: | :white_check_mark: | :white_check_mark: | 82712 (3%) | ø | 22232 (4%) | ø | | spike_lk_touch_sensor_kit | :heavy_check_mark: | :white_check_mark: | :white_check_mark: | 96668 (4%) | ø | 23392 (4%) | ø | | spike_lk_update_process_app_base | :heavy_check_mark: | :white_check_mark: | :white_check_mark: | 157932 (7%) | ø | 26288 (5%) | ø | | spike_lk_update_process_app_update | :heavy_check_mark: | :white_check_mark: | :white_check_mark: | 100456 (4%) | ø | 23240 (4%) | ø | | spike_lk_watchdog_isr | :heavy_check_mark: | :white_check_mark: | :white_check_mark: | 87520 (4%) | ø | 24136 (4%) | ø | | spike_lk_wifi | :heavy_check_mark: | :white_check_mark: | :white_check_mark: | 130984 (6%) | ø | 25528 (4%) | ø | | spike_mbed_blinky | :heavy_check_mark: | :white_check_mark: | :white_check_mark: | 57616 (2%) | ø | 11496 (2%) | ø | | spike_mbed_watchdog_ticker_vs_thread | :heavy_check_mark: | :white_check_mark: | :white_check_mark: | 84176 (4%) | ø | 23080 (4%) | ø | | spike_stl_cxxsupport | :heavy_check_mark: | :white_check_mark: | :white_check_mark: | 83488 (3%) | ø | 22304 (4%) | ø | ## :world_map: Map files diff output No differenes where found in map files.
github-actions[bot] commented 1 year ago

:chart_with_upwards_trend: Changes Impact Analysis Report

:pushpin: Info

base head
branch develop ladislas/feature/color-kit-add-const
sha c00770c9 9e42bc68
mbed mbed-os@master+fixes+gcc-11-support mbed-os@master+fixes+gcc-11-support
-std -std=c++20 -std=c++20

:robot: Firmware impact analysis

Target Flash Used (base/head) Flash Used Δ Flash Available (base/head) Static RAM (base/head) Static RAM Δ
bootloader 170888 (65%) ø 91256 (34%)
91256 (34%)		 30960 (5%) ø
os 445880 (28%) ø 1118792 (71%)
1118792 (71%)		 83880 (15%) ø
Click to show memory sections ``` | - | Hex | Bytes | KiB | |------------|---------:|----------:|-----:| | Flash | 0x200000 | 2 097 152 | 2048 | | SRAM | 0x80000 | 524 288 | 512 | | Bootloader | 0x40000 | 262 144 | 256 | | Header | 0x1000 | 4 096 | 4 | | OS | 0x17E000 | 1 564 672 | 1528 | | Tail | 0x1000 | 4 096 | 4 | | Scratch | 0x40000 | 262 144 | 256 | ```

:microscope: Detailed impact analysis

Click to show detailed analysis for all targets - :heavy_check_mark: - existing target - :sparkles: - new target - :coffin: - deleted target - :white_check_mark: - files are the same - :x: - files are different | Target | Status | .bin | .map | Total Flash (base/head) | Total Flash Δ | Static RAM (base/head) | Static RAM Δ | |-------|:------:|:------:|:------:|:------:|:------:|:------:|:------:| | LekaOS | :heavy_check_mark: | :white_check_mark: | :white_check_mark: | 445880 (21%) | ø | 83880 (15%) | ø | | bootloader | :heavy_check_mark: | :white_check_mark: | :white_check_mark: | 170888 (8%) | ø | 30960 (5%) | ø | | functional_ut_boost_ut | :heavy_check_mark: | :white_check_mark: | :white_check_mark: | 394140 (18%) | ø | 20456 (3%) | ø | | functional_ut_core_imu | :heavy_check_mark: | :white_check_mark: | :white_check_mark: | 377656 (18%) | ø | 20968 (3%) | ø | | functional_ut_deep_sleep_core_buffered_serial | :heavy_check_mark: | :white_check_mark: | :white_check_mark: | 360600 (17%) | ø | 20440 (3%) | ø | | functional_ut_deep_sleep_core_motor | :heavy_check_mark: | :white_check_mark: | :white_check_mark: | 364540 (17%) | ø | 20480 (3%) | ø | | functional_ut_deep_sleep_core_pwm | :heavy_check_mark: | :white_check_mark: | :white_check_mark: | 366676 (17%) | ø | 20480 (3%) | ø | | functional_ut_deep_sleep_log_kit | :heavy_check_mark: | :white_check_mark: | :white_check_mark: | 352568 (16%) | ø | 20408 (3%) | ø | | functional_ut_deep_sleep_mbed_hal | :heavy_check_mark: | :white_check_mark: | :white_check_mark: | 354344 (16%) | ø | 20408 (3%) | ø | | functional_ut_file_manager | :heavy_check_mark: | :white_check_mark: | :white_check_mark: | 376272 (17%) | ø | 20696 (3%) | ø | | functional_ut_firmware_kit | :heavy_check_mark: | :white_check_mark: | :white_check_mark: | 367084 (17%) | ø | 20688 (3%) | ø | | functional_ut_imu_kit | :heavy_check_mark: | :white_check_mark: | :white_check_mark: | 381348 (18%) | ø | 21144 (4%) | ø | | functional_ut_io_expander | :heavy_check_mark: | :white_check_mark: | :white_check_mark: | 359576 (17%) | ø | 20424 (3%) | ø | | functional_ut_qdac | :heavy_check_mark: | :white_check_mark: | :white_check_mark: | 360744 (17%) | ø | 20424 (3%) | ø | | spike_lk_audio | :heavy_check_mark: | :white_check_mark: | :white_check_mark: | 127092 (6%) | ø | 14592 (2%) | ø | | spike_lk_behavior_kit | :heavy_check_mark: | :white_check_mark: | :white_check_mark: | 189440 (9%) | ø | 48096 (9%) | ø | | spike_lk_ble | :heavy_check_mark: | :white_check_mark: | :white_check_mark: | 229600 (10%) | ø | 28472 (5%) | ø | | spike_lk_bluetooth | :heavy_check_mark: | :white_check_mark: | :white_check_mark: | 82948 (3%) | ø | 11544 (2%) | ø | | spike_lk_cg_animations | :heavy_check_mark: | :white_check_mark: | :white_check_mark: | 145976 (6%) | ø | 46528 (8%) | ø | | spike_lk_color_kit | :heavy_check_mark: | :white_check_mark: | :white_check_mark: | 65840 (3%) | ø | 13744 (2%) | ø | | spike_lk_command_kit | :heavy_check_mark: | :white_check_mark: | :white_check_mark: | 220552 (10%) | ø | 52872 (10%) | ø | | spike_lk_config_kit | :heavy_check_mark: | :white_check_mark: | :white_check_mark: | 127324 (6%) | ø | 14360 (2%) | ø | | spike_lk_coreled | :heavy_check_mark: | :white_check_mark: | :white_check_mark: | 76292 (3%) | ø | 13688 (2%) | ø | | spike_lk_core_touch_sensor | :heavy_check_mark: | :white_check_mark: | :white_check_mark: | 80508 (3%) | ø | 12248 (2%) | ø | | spike_lk_event_queue | :heavy_check_mark: | :white_check_mark: | :white_check_mark: | 74800 (3%) | ø | 12072 (2%) | ø | | spike_lk_file_manager_kit | :heavy_check_mark: | :white_check_mark: | :white_check_mark: | 139528 (6%) | ø | 14440 (2%) | ø | | spike_lk_file_reception | :heavy_check_mark: | :white_check_mark: | :white_check_mark: | 336000 (16%) | ø | 27792 (5%) | ø | | spike_lk_flash_memory | :heavy_check_mark: | :white_check_mark: | :white_check_mark: | 63880 (3%) | ø | 11448 (2%) | ø | | spike_lk_fs | :heavy_check_mark: | :white_check_mark: | :white_check_mark: | 175668 (8%) | ø | 47928 (9%) | ø | | spike_lk_imu_kit | :heavy_check_mark: | :white_check_mark: | :white_check_mark: | 98700 (4%) | ø | 13016 (2%) | ø | | spike_lk_lcd | :heavy_check_mark: | :white_check_mark: | :white_check_mark: | 163352 (7%) | ø | 46680 (8%) | ø | | spike_lk_led_kit | :heavy_check_mark: | :white_check_mark: | :white_check_mark: | 103424 (4%) | ø | 14528 (2%) | ø | | spike_lk_log_kit | :heavy_check_mark: | :white_check_mark: | :white_check_mark: | 63288 (3%) | ø | 12256 (2%) | ø | | spike_lk_motion_kit | :heavy_check_mark: | :white_check_mark: | :white_check_mark: | 111972 (5%) | ø | 15408 (2%) | ø | | spike_lk_motors | :heavy_check_mark: | :white_check_mark: | :white_check_mark: | 62864 (2%) | ø | 11488 (2%) | ø | | spike_lk_qdac | :heavy_check_mark: | :white_check_mark: | :white_check_mark: | 78852 (3%) | ø | 11808 (2%) | ø | | spike_lk_reinforcer | :heavy_check_mark: | :white_check_mark: | :white_check_mark: | 217768 (10%) | ø | 50064 (9%) | ø | | spike_lk_rfid | :heavy_check_mark: | :white_check_mark: | :white_check_mark: | 79084 (3%) | ø | 11504 (2%) | ø | | spike_lk_sensors_battery | :heavy_check_mark: | :white_check_mark: | :white_check_mark: | 78388 (3%) | ø | 12600 (2%) | ø | | spike_lk_sensors_imu_lsm6dsox | :heavy_check_mark: | :white_check_mark: | :white_check_mark: | 89468 (4%) | ø | 12824 (2%) | ø | | spike_lk_sensors_imu_lsm6dsox_fusion_calibration | :heavy_check_mark: | :white_check_mark: | :white_check_mark: | 97916 (4%) | ø | 12952 (2%) | ø | | spike_lk_sensors_light | :heavy_check_mark: | :white_check_mark: | :white_check_mark: | 60056 (2%) | ø | 11440 (2%) | ø | | spike_lk_sensors_microphone | :heavy_check_mark: | :white_check_mark: | :white_check_mark: | 72496 (3%) | ø | 11504 (2%) | ø | | spike_lk_sensors_temperature_humidity | :heavy_check_mark: | :white_check_mark: | :white_check_mark: | 67272 (3%) | ø | 11424 (2%) | ø | | spike_lk_serial_number | :heavy_check_mark: | :white_check_mark: | :white_check_mark: | 133084 (6%) | ø | 14304 (2%) | ø | | spike_lk_ticker_timeout | :heavy_check_mark: | :white_check_mark: | :white_check_mark: | 69052 (3%) | ø | 11632 (2%) | ø | | spike_lk_touch_sensor_kit | :heavy_check_mark: | :white_check_mark: | :white_check_mark: | 87896 (4%) | ø | 12824 (2%) | ø | | spike_lk_update_process_app_base | :heavy_check_mark: | :white_check_mark: | :white_check_mark: | 145620 (6%) | ø | 15576 (2%) | ø | | spike_lk_update_process_app_update | :heavy_check_mark: | :white_check_mark: | :white_check_mark: | 77632 (3%) | ø | 12352 (2%) | ø | | spike_lk_watchdog_isr | :heavy_check_mark: | :white_check_mark: | :white_check_mark: | 80196 (3%) | ø | 13288 (2%) | ø | | spike_lk_wifi | :heavy_check_mark: | :white_check_mark: | :white_check_mark: | 116544 (5%) | ø | 14808 (2%) | ø | | spike_mbed_blinky | :heavy_check_mark: | :white_check_mark: | :white_check_mark: | 58032 (2%) | ø | 11400 (2%) | ø | | spike_mbed_watchdog_ticker_vs_thread | :heavy_check_mark: | :white_check_mark: | :white_check_mark: | 63208 (3%) | ø | 12448 (2%) | ø | | spike_stl_cxxsupport | :heavy_check_mark: | :white_check_mark: | :white_check_mark: | 58456 (2%) | ø | 11400 (2%) | ø | ## :world_map: Map files diff output No differenes where found in map files.
codecov[bot] commented 1 year ago

Codecov Report

Merging #1313 (9e42bc6) into develop (c00770c) will increase coverage by 0.00%. The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop    #1313   +/-   ##
========================================
  Coverage    98.73%   98.73%           
========================================
  Files          145      145           
  Lines         3729     3730    +1     
========================================
+ Hits          3682     3683    +1     
  Misses          47       47
Impacted Files Coverage Δ
libs/ColorKit/source/conversion.cpp 100.00% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information