search

lekeno / edr

ED Recon is an EDMC plugin for Elite Dangerous whose purpose is to provide intel about other commanders and in-game guidance for traders, explorers, bounty-hunters, and powerplay pledges.
https://edrecon.com
Apache License 2.0
86 stars 14 forks source link

Have EDR clients use mirrored Inara info on EDR server #174

Closed lekeno closed 4 years ago

lekeno commented 6 years ago

It's probably more efficient to have the EDR backend do the Inara API calls and provide a global cache than having each EDR clients do the Inara calls and rely on a per client cache.

Athanasius commented 5 years ago

Not to mention that you're putting 'your' Inara API key out there in the config.ini contained in the release .zip. That's really not the intended use of such API keys. I do wonder about the security implications of that Firebase API key in there as well (but for all I know that one is purely read-only).

I'd highly recommend you change things so that you ask the EDR User for their own Inara API key to use for that functionality.

lekeno commented 5 years ago

@Athanasius the Firebase API Key is meant to be public