lekez2005 / opennvram-reram

Other
4 stars 0 forks source link

The python3 21_reram_simulation_test.py -t sky130 -v --num_banks=1 --num_cols=16 --word_size=16 --num_words=16 #13

Closed Samarthjainabout closed 1 year ago

Samarthjainabout commented 1 year ago

The script gets stuck for 3 hours image

lekez2005 commented 1 year ago

I'm unable to reproduce this locally. Can you run with -vv instead for a more verbose log? i.e. python3 21_reram_simulation_test.py -t sky130 -vv --num_banks=1 --num_cols=16 --word_size=16 --num_words=16. You can attach the log file to a comment for review

Samarthjainabout commented 1 year ago

The error is weird. says the file is not there but when I check the file using less I can see it in the same path.I have attached the whole log folder as well.

image reram_16_c_16_w16.zip

image image

lekez2005 commented 1 year ago

From those logs I can see that the temporary directory wasn't being adequately set when the SCRATCH environment variable is not defined. I have pushed a fix to use /tmp if $SCRATCH is not set. Can you test if that works?

Samarthjainabout commented 1 year ago

after updates still following errors.cant see error in log but warnings image openram.log

lekez2005 commented 1 year ago

Alright, looks like that fixed the previous issue. I'll need to take a closer look at either the magic version or the PDK version. I see you're using magic version 8.3.358 based on the logs while I'm still on 8.3.309. I'll get back to you once I test with version 8.3.358

lekez2005 commented 1 year ago

I have been able to reproduce this bug using magic version 8.3.358. I don't really know what changed to break the extraction scripts. You can use magic version 8.3.309 until I further investigate how to correctly use the latest version of magic.

-- Edited link

Samarthjainabout commented 1 year ago

its 8.3.309 or 8.3.310?

I have been able to reproduce this bug using magic version 8.3.358. I don't really know what changed to break the extraction scripts. You can use magic version 8.3.309 until I further investigate how to correctly use the latest version of magic.

lekez2005 commented 1 year ago

Yeah, sorry 8.3.309. Edited to reflect the correct link

Samarthjainabout commented 1 year ago

after changing magic,i get the following error. image

openram.log

lekez2005 commented 1 year ago

Did you modify the sense amp? This step was successfully run in the previous log file you posted which suggests to me that you've modified the sense amplifier

Samarthjainabout commented 1 year ago

I havent chnaged the sense

Did you modify the sense amp? This step was successfully run in the previous log file you posted which suggests to me that you've modified the sense amplifier

lekez2005 commented 1 year ago

I havent chnaged the sense

Did you modify the sense amp? This step was successfully run in the previous log file you posted which suggests to me that you've modified the sense amplifier

I suspect the reason this didn't work is because you didn't specify to re-run extractions. By default, extraction is only run if a pex.sp file doesn't already exist since extraction takes a long time. The --run_pex explicit flag exists to enforce re-running extraction. FYI, if you make changes, --run_drc and --run_lvs should also be specified to ensure drc and lvs are run on the newest versions. The full command would look like: python3 21_reram_simulation_test.py -t sky130 -v --num_banks=1 --num_cols=16 --word_size=16 --num_words=16 --run_drc --run_lvs --run_pex

lekez2005 commented 1 year ago

I have been able to reproduce this bug using magic version 8.3.358. I don't really know what changed to break the extraction scripts. You can use magic version 8.3.309 until I further investigate how to correctly use the latest version of magic.

-- Edited link

I found the issue: magic changed the extraction netlist's hierarchy separator in later versions from '/' to '.'. I have pushed changes to fix this so you should be able to use the latest version of magic again

Samarthjainabout commented 1 year ago

python3 21_reram_simulation_test.py -t sky130 -v --num_banks=1 --num_cols=16 --word_size=16 --num_words=16 --run_drc --run_lvs --run_pex

after I run this command, it gives same error? image openram.log

lekez2005 commented 1 year ago

python3 21_reram_simulation_test.py -t sky130 -v --num_banks=1 --num_cols=16 --word_size=16 --num_words=16 --run_drc --run_lvs --run_pex

after I run this command, it gives same error? image openram.log

Just realized this is a different error from the one fixed by my magic-related changes. I am unable to reproduce this error from a fresh checkout of the repository. Can you try to reproduce this with a completely clean checkout from the repo? If it still happens, you can also attach the temp.sp spice file in the temp directory?

Samarthjainabout commented 1 year ago

Hi, I tried with latest git file and magic version 8.3.358 and got the same error. PFA Logfiles and temp.sp openram.zip

lekez2005 commented 1 year ago

As discussed offline, this issue was because OPENRAM_HOME environment variable was different from the location of the actual code.