search

lekma / plugin.video.invidious

Invidious Addon for Kodi
GNU General Public License v3.0
50 stars 7 forks source link

Feature request: SponsorBlock #71

Closed maybebyte closed 1 year ago

maybebyte commented 2 years ago

This may be asking a lot. I was wondering if support for SponsorBlock is a feasible thing to include, either in this repository or as a separate companion add-on. I use the mpv_sponsorblock_minimal script with mpv and always miss this feature when using Invidious on Kodi. Especially on videos with a lower signal-to-noise ratio (videos with many sponsorships and unneeded fluff).

There is a SponsorBlock add-on for YouTube, but I would rather not use the YouTube add-on for the sake of privacy (it requires unique API keys associated to a particular identity).

Maybe it would be better to write a more generic add-on that can perform this functionality with any media file/stream, but sadly I currently lack the know-how to do it myself...

probonopd commented 1 year ago

This would be a killer feature. I think the unique keys are needed for SponsorBlock to distinguish different clients.

Would it be possible to utilize the existing https://github.com/siku2/script.service.sponsorblock with plugin.video.invidious? Would the modifications need to be made in script.service.sponsorblock and/or in plugin.video.invidious?

SethFalco commented 1 year ago

Not merged yet, but I opened a PR to script.service.sponsorblock to support this addon. I have my branch running on my RockPro64, and it's working quite well, so it should be stable. :+1:

SethFalco commented 1 year ago

The PR above was merged!

Could be worth documenting that one can install and use that repo from the README here. I'll submit a PR later that closes this one.

lekma commented 1 year ago

@SethFalco: if you submit a PR, please, do it against the sponsorblock branch, thanks

SethFalco commented 1 year ago

Hmm, this didn't get closed. Maybe because the PR was to sponsorblock branch rather than master. Just noting it here so when/if it does get merged to master, you know you can close this. :+1:

SethFalco commented 9 months ago

@SethFalco: if you submit a PR, please, do it against the sponsorblock branch, thanks

@lekma Hey! Any chance the sponsorblock branch can be merged with master at some point? Unless you have any qualms with it, I think it'd be very nice to have the revamped README including reference to SponsorBlock more visible on the project.