Closed aiosk closed 2 years ago
unfortunately I have no way to test all that at the moment, so I'll have to trust that you did test somewhat extensively, right? i'd especially try to put weird unicode characters (emojis, and such) in you json file to test that they are imported correctly. but if you can confirm that it's all alright, then, yeah, i would gladly merge.
for thre removeAll in persistence.py I would rename it to clear and call super on it (see SearchCache and SearchHistory in the same file).
thanks for the contribution
unfortunately I have no way to test all that at the moment, so I'll have to trust that you did test somewhat extensively, right? i'd especially try to put weird unicode characters (emojis, and such) in you json file to test that they are imported correctly. but if you can confirm that it's all alright, then, yeah, i would gladly merge.
sorry, i only test it against my newpipe-subscriptions.json. I'll try my best to mitigate such case.
for thre removeAll in persistence.py I would rename it to clear and call super on it (see SearchCache and SearchHistory in the same file).
i will
thanks for your reply and suggestion
@lekma, i have no problem importing CJK characters and emoji in channel name, instead i have problem viewing these characters. Here is my finding:
@lekma, i have no problem importing CJK characters and emoji in channel name
good, this is what i wanted to confirm
instead i have problem viewing these characters.
this is an old kodi constraint/bug (it does not use system fonts), as you experienced, there isn't much we can do, as users, but tinker with the fonts...
question: is the clear() before importing really necessary? if you have common ids between the ones already existing and the ones being imported they will be updated, right? (there is no need to fix in the pr, i'll adjust before release)
request: would you mind attaching your json file (unless there is sensitive info inside) or point me to a sample i can download so that i can at least pretend i tried to test the feature :smile: ?
also, thanks again for the contribution
@aiosk: it seems I forgot to tag you
would you mind testing current master (or the file attached) and report?
thanks for your help plugin.video.invidious-1.0.9-c6c9e76.zip
@aiosk: forgot to tag you
question: is the clear() before importing really necessary? if you have common ids between the ones already existing and the ones being imported they will be updated, right? (there is no need to fix in the pr, i'll adjust before release)
no, .clear()
is really not necessary.
I add .clear()
because i really want the easy way to remove multiple subscriptions. As an alternative you can always remove channel from feed too..
come to think of it,, i think what i really want is more of sync subscriptions feature rather than just import.
request: would you mind attaching your json file (unless there is sensitive info inside) or point me to a sample i can download so that i can at least pretend i tried to test the feature smile ?
well i don't mind posting a subset of my json file..
would you mind testing current master (or the file attached) and report? plugin.video.invidious-1.0.9-c6c9e76.zip
i tested it.. very nice.. exactly what i want..
thank you @lekma and you're welcome
Condition:
Expected:
Actual:
Known Issue: i have to save
subscription path
to settings.xml by clickok
first before i can runimport to feed
. ideally i wantimport feed
after i setsubscription path
without clickok
firstReference:
Tips convert youtube channel to newpipe-subcriptions.json
copy paste this snippet, then press enter
snippet.js
```js ytContents = ytInitialData.contents.twoColumnBrowseResultsRenderer.tabs[0].tabRenderer.content.sectionListRenderer.contents; window.prompt( 'CTRL+A, CTRL+C', JSON.stringify({ "app_version": "0.19.8", "app_version_int": 953, 'subscriptions': ytContents[0].itemSectionRenderer.contents[0].shelfRenderer.content.expandedShelfContentsRenderer.items.map(item => ({ 'service_id': 0, 'url': `https://www.youtube.com/channel/${item.channelRenderer.channelId}`, 'name': item.channelRenderer.title.simpleText })) }) ) ```