ux: move search to top - Githubissues

lekma / plugin.video.invidious

Invidious Addon for Kodi

GNU General Public License v3.0

50 stars 7 forks source link

ux: move search to top #87

Closed SethFalco closed 1 year ago

SethFalco commented 1 year ago

This does a minor UX improvement:

pressing an old search will bring it back to the top of the search history.
searching something that was already searched before (i.e. very far down in the list) also brings it back to the top.

Note

I changed SearchHistory to use OrderedDict for persistence, and override __setitem__ to cast any values to an OrderedDict heeding your advice in script.module.iapc/issues/3.
On the side, I renamed some instances of type to search_type to avoid shadowing the built-in type function. I was using this while trying to figure out why #move_to_end wasn't working, but the shadowing was getting in the way.

Related

Implementation impacted by https://github.com/lekma/script.module.iapc/issues/3#issue-1740654152

SethFalco commented 1 year ago

I made a change since opening this PR.

I added SearchHistory#move_to_end so we can move a search history entry to the end without doing the two-step process of getting the previous sort_by before calling #record.

Please let me know if you have any qualms with this!