search

lekma / plugin.video.invidious

Invidious Addon for Kodi
GNU General Public License v3.0
50 stars 7 forks source link

chore: add country to server list #88

Closed SethFalco closed 1 year ago

SethFalco commented 1 year ago

Adds the region of an instance in brackets in the public server list.

Sometimes an instance takes too long to respond, or is just overloaded. When this happens, the user has to switch instance, so it helps set out some criteria to aid the user in choosing one.

Normally, I think showing latency next to each server would be best, but it's not ideal to ping or hit GET /stats on each public instance without the user's permission. Plus, it'd make loading the instances list even slower, which would make for a shoddy UX.

As an alternative, since we already have the region information available, we can just display that next to the server name. I already check this personally when picking an instance, so it'll be very convenient to have this information available inside the addon.

I prefer to use instances in Europe, for example, and usually get the best latency to instances in Germany (DE) or Finland (FI).

I did consider using the region's flag instead, but unfortunately not all skins/themes will display them, including mine, which is the default.

Screenshots

image

See the help text in blue at the bottom.

image

See how in brackets after each instance name, it shows the region in brackets.

PS: Ignore the Auto-select instance setting, that's just me working on adding auto-selecting servers, but that'll take me some time, so figured I'd PR this already.

lekma commented 1 year ago

good idea I might put the region first in label. something like: [DE] - y.com.sb, is that ok?

SethFalco commented 1 year ago

I'd be alright with that personally, so if you think it's better, go for it!

I don't have a strong preference in general either though. If I was being nitpicky, I do like the part that is fixed width being at the start. :thinking:

Edit: Ahh, actually the nitpicky point is irrelevant. This isn't monospace. ^-^' Either way, fine with either so long as the information is available. :tada:

lekma commented 1 year ago

should we also sort by location instead of health?

Edit: something like: image

SethFalco commented 1 year ago

I'm partial to this one.

Logically, I think sorting by health makes a lot of sense. But from a UX perspective, I actually didn't like it because that fact is not indicating at all to the user, so it just looks like it's random.

Sorting by something that is actually visible to the user would be nice tbh. :thinking:

Overall, I think that's a good change. But not because I think region is more important than health, but rather because the user can actually see that it's sorted and how it's sorted.

lekma commented 1 year ago

ok, thanks for the input