search

lekoala / silverstripe-debugbar

SilverStripe DebugBar module
MIT License
56 stars 27 forks source link

PHP 7.2 upgrade #111

Closed adrian-stein closed 5 years ago

adrian-stein commented 5 years ago

Is there any plans to make this compatible with 7.2. I notice there is a Object extends in DebugBar.php. Would this be the only amend to get it working with 7.2??

robbieaverill commented 5 years ago

Hey @adrian-stein, we'd welcome a pull request to implement compatibility with PHP 7.2. You can have a look at most of the commercially supported SilverStripe modules (blog, userforms, etc) for examples of how to do this - e.g. this commit.

sminnee commented 5 years ago

PR in #112

robbieaverill commented 5 years ago

Done in #112 and tagged as 1.2.0-beta1