search

lektor / lektor-atom

Lektor Atom plugin.
30 stars 13 forks source link

Replace deprecated Werkzeug's atom with Pelican's feedgenerator #25

Closed eigenwijsje closed 4 years ago

eigenwijsje commented 5 years ago

This replaces Werkzeug's Atom with Pelican's feedgenerator and fixes #23

The changes are rather minimal.

I ended using feedgenerator because it seems a more natural fit. I coudn't get the unit tests to pass with feedgen.

The unit tests pass, with some parts commented out. The feed generated are still valid, although some attributes are missing.

franktisellano commented 4 years ago

@nixjdm Can this change be merged into master?

FranklinYu commented 4 years ago

@nixjdm Any comment/question? How can we help?

FranklinYu commented 4 years ago

@goanpeca Please take a look?

goanpeca commented 4 years ago

I will later today ;-)

FranklinYu commented 4 years ago

@goanpeca Any update? Do you need any help?

dzc0d3r commented 4 years ago

Can we get this change merged ?

runfalk commented 4 years ago

It's actually no longer possible to merge it since the original PR repository has been deleted and can longer cleanly be applied to master. We need to manually apply the changes and redo the PR. I'd be happy to review and merge such work if someone opens a new PR.

xlotlu commented 4 years ago

@runfalk I'm on this. I used this procedure https://docs.github.com/en/github/collaborating-with-issues-and-pull-requests/checking-out-pull-requests-locally to preserve the original work.

and can longer cleanly be applied to master

Another reason why black is evil.

xlotlu commented 4 years ago

This has been updated in #31. @nnrcschmdt thanks for your work.