lektor / lektor-atom

Lektor Atom plugin.
30 stars 13 forks source link

PR: Add CI with github actions #28

Closed goanpeca closed 4 years ago

goanpeca commented 4 years ago

Fixes #23

goanpeca commented 4 years ago

@nixjdm could you please add the pypi getlektor user as collaborator of the lektor-atom package?

This way I can create a token for this project linked to that user to make the package upload to PyPI

Thanks!

runfalk commented 4 years ago

Very nice work. I think Linux testing is enough as well.

goanpeca commented 4 years ago

I figured I would use this as a test repo for the pre-commit black stuff. It is small enough that we do not really care about splitting this into many commits :-)

runfalk commented 4 years ago

I don't mind adding black in the same PR, but I think we should at least add it in its own commit. Otherwise the history will be a giant mess.

goanpeca commented 4 years ago

For such a small project I think it is a bit irrelevant, but if you guys think it is better to do the one commit workflow, I can do a separate PR (just for cleanliness)

goanpeca commented 4 years ago

@runfalk ok, I left all the machinery but reversed the python formatting and will do in a separate PR and commit :-p. It is more tidy even for a small project.

nixjdm commented 4 years ago

@goanpeca getlektor is now an owner of this and lektor-tags on pypi. :)

goanpeca commented 4 years ago

Added the secrets, this PR should be ready now :-)

runfalk commented 4 years ago

Looks good to me, feel free to merge whenever CI completes.