search

lektor / lektor-atom

Lektor Atom plugin.
30 stars 13 forks source link

Import werkzeug's atom.py #30

Closed xlotlu closed 4 years ago

xlotlu commented 4 years ago

I have imported atom.py into lib/ from werkzeug 0.16, preserving all history. I used git-filter-repo for the job.

The only relevant commits are the last ones.

runfalk commented 4 years ago

I like this approach. Not sure why the tests are failing though :thinking:

xlotlu commented 4 years ago

@runfalk, I was just loading this page with the intent to close the PR.

I only discovered #25 now, and I think that it's the way to go. We shouldn't burden ourselves with the maintenance of the underlying lib when there's a mature solution out there. It's sourced from django and it is maintained.

I dislike a few things about that particular PR, but I think we should get rid of this thing I tried here. What do you think?

runfalk commented 4 years ago

Sure, I think that either PR is fine. I don't think there is much in terms of maintenance burden in using werkzeug's old implementation. The spec has looked the same for so many years so I think it's a non-issue. If you feel like fixing the old PR I'll be happy to review that as well.