search

lektor / lektor-website

The main lektor website.
https://www.getlektor.com/
Other
160 stars 134 forks source link

added page for bibtex-support plugin #215

Closed arunpersaud closed 6 years ago

nixjdm commented 6 years ago

Thank you for your submission!

Could you please add at some tags for this page? At least setup-env and jinja globals, and maybe LaTeX?

arunpersaud commented 6 years ago

Added some tags, not 100% how the tag mechanism works, hope I got this right.

nixjdm commented 6 years ago

This PR looks good!

A note about the readme though, https://pypi.org/project/lektor-bibtex-support/0.1/ isn't rendering as markdown. This might be because your wheel, twine, or setuptools aren't up-to-date, since 'text/markdown' is pretty new. You may want to check that. In general, getlektor will render the markdown iff pypi does.

goanpeca commented 6 years ago

So maybe its time to update a bugfix release 0.1.1 with the updates :-p @arunpersaud ?

Side note is https://pypi.org/project/lektor-bibtex-support/0.1/ not py27 compatible?

nixjdm commented 6 years ago

I'm checking the language on the publishing page to see if I can make this more clear, too. Somehow I expect this to be a common problem. I'd like to help other future plugin devs avoid that if I can.

arunpersaud commented 6 years ago

will try this out. This was the first time I submitted something to PyPi and I ran into several issues. First of all, publishing with lektor directly didn't work (there seems already to be an issue open for it) and then my twine was outdated... I also had to install wheel. I normally use the packages that come with my distribution (openSUSE) and I think they have several updates pending for those packages. I will try again in a few days.

nixjdm commented 6 years ago

I normally use the packages that come with my distribution (openSUSE)

Oh yeah, I would expect OS level packages for python to be somewhat out of date, and the text/markdown stuff is only a couple months old. I highly recommend (for python work) to use some sort of virtual environment to straighten out package management.

publishing with lektor directly didn't work

Can you elaborate? Does https://github.com/lektor/lektor/issues/536 fit your problem?

nixjdm commented 6 years ago

@arunpersaud I'm going to go ahead an pull this. The PR is good and a long_description will still appear and be readable.

I do encourage you to reupload a version bump with updated packages, to have the markdown be rendered. I've add notes about that here: https://www.getlektor.com/docs/plugins/publishing/#listing-on-this-site. When you do, this site will take the update on its next build which is at least daily.

Thanks! And invite to the plugin-devs group incoming.

arunpersaud commented 6 years ago

if I update all the required packages (wheel, etc) how do I know if the markup upload works? Do I need to upload a new version for every test I do or can I just reupload the package (nothing will have changed after all)?

nixjdm commented 6 years ago

@arunpersaud You can upload to https://test.pypi.org/. I don't have recent experience with that since the old site was replaced. It used to be (I think) that version names still needed to be unique. So if you test it there, you may want to go with a version name you don't care about, like 0.1b or something.

arunpersaud commented 6 years ago

thanks for the tips. Just uploaded 0.1.1 seems the README parsed OK this time.