lelandrichardson / react-primitives

Primitive React Interfaces Across Targets
MIT License
3.09k stars 108 forks source link

Support for latest react-web-native #109

Closed jcampbell05 closed 6 years ago

jcampbell05 commented 6 years ago

Is it possible to support the latest react-web-native, this has bug fixes that resolve issues in older browsers.

mathieudutour commented 6 years ago

Can you create a PR? Happy to merge it

jcampbell05 commented 6 years ago

Sure I'll try and get it working

necolas commented 6 years ago

I think you're better off aliasing package names than using this package. It's out of date and the exported API is not compatible with the rest of the React Native ecosystem

mathieudutour commented 6 years ago

wait you meant react-native-web right?

jcampbell05 commented 6 years ago

Yes I did, I've tried to update it on a new branch but it breaks.

zephraph commented 6 years ago

I think you're better off aliasing package names than using this package. It's out of date and the exported API is not compatible with the rest of the React Native ecosystem

@necolas What do you mean by that exactly? react-native-web is out of date? Or this package?

jcampbell05 commented 6 years ago

This package is out of date, it uses an old version of the native-web package. I tried upgrading the version and using the new StyleManager class but it's a non trivial change as things like transform is broken