search

lelandrichardson / react-primitives

Primitive React Interfaces Across Targets
MIT License
3.09k stars 108 forks source link

Is this in active development? #146

Open testavenger opened 1 year ago

macintoshhelper commented 1 year ago

Hi, you can check the git history; there haven’t been any new features/major code changes in a while, I believe the repository is more in maintenance mode with PRs being accepted for fixes or new platforms.

It’s intended to be quite a minimalist project and still works fine. I’m working on a sort of fork/evolution to this project over here: https://github.com/elemental-design/react-platform

react-native-web support appears to be broken currently though with the latest version due to createStyleResolver.js being removed: https://github.com/necolas/react-native-web/commit/b27c9820dbffe1e5a3ffc87d62b1c9c167dbae8c#diff-40578f626041a46abbd28a6414da8ace7a395d2039c00d3646368f177e457160 . I may take a look at this and contribute a fix later.

badsyntax commented 1 year ago

I've added a PR to remove Stylesheet.resolve: https://github.com/lelandrichardson/react-primitives/pull/148

nilooy commented 1 year ago

can we prioritise the merge of the pr mentioned above please? the library seems to be non functional for react-native-web without that.

macintoshhelper commented 1 year ago

@nilooy

I’ve added a comment to the PR re backwards compatibility. If this is a blocker for you and there’s no feedback from any maintainers re a potential merge, I’d be happy to copy the PR over to my fork and publish the updated fork to npm.

nilooy commented 1 year ago

@macintoshhelper that will be amazing, i was already copying it with typescript support, if you can do the copy, that will help a lot.

nilooy commented 1 year ago

i tried with local clone of the package, but if i apply https://github.com/lelandrichardson/react-primitives/pull/148 changes to fix the issue, then no styling worked on primitive for web.