search

lelandrichardson / react-primitives

Primitive React Interfaces Across Targets
MIT License
3.09k stars 108 forks source link

Still maintained? #92

Closed samjt closed 6 years ago

samjt commented 7 years ago

Is this project still active?

There are a few outstanding issues with pull requests open to fix those issues, but no activity from the contributors on either merging them or even rejecting them.

I started building a library of components around react-primitives, mostly because of react-sketchapp support, but also the idea of rendering to multiple platforms from one codebase. Now i'm slightly regretting that choice as it looks like this might be dead?

samjt commented 7 years ago

@jongold might this be rolled into react-sketchapp or supported by airbnb?

jemgold commented 7 years ago

@samjt it won't be rolled into react-sketchapp (because it should be separate from any particular implementation), but I hear you that we should make progress on PRs & issues — sorry for the tardiness!

dmiller9911 commented 7 years ago

If anyone is interested, I was a little impatient and forked this and published under react-bits.
The Repo can be found here: https://github.com/dmiller9911/react-bits

It is a one to one copy of the repo so it should be as easy as aliasing react-primitives to point to it. I would love for maintenance to continue in this repo, but until it does, I plan to maintain a working codebase in my fork. I was able to verify RN (v0.49.3), Web, and VR with React v16. I do not have a Mac, so I am unable to verify React SketchApp. I will gladly accept PR's for any bugs.

I am definitely not trying to discredit any of the great work done here. The idea is great, and is the reason for my drive to use this to create some cross platform components. Thanks for the hard work on this!

ljharb commented 7 years ago

@dmiller9911 it seems like the first step, before forking, would be to open a PR to try to get your changes in :-) can't get impatient if there's nothing to be waiting for!

dmiller9911 commented 7 years ago

Could not agree more. I commented in the React 16 support PR a few days ago. It has a few comments waiting for merges, and I have been watching it. Unfortunately I do not believe it will fix React 16 for web since react-native-web did not add support until 0.1.0, and the dependency is listed as 0.0.x in the repo.

I fully agree forking is not the answer, and the project was only meant to be temporary until the maintainers have time to look at open PRs. I was only hoping to give people an option while they wait.

samjt commented 7 years ago

To be fair to @dmiller9911, the Touchable injection fix was waiting to be merged for something like 3 months, with the issue reported way back in July. I can understand his frustration, I almost forked the repo as well but decided against it.

samjt commented 7 years ago

We've decided to remove primitives from our projects, the development process is too unreliable for us at the moment and we don't have the resources to maintain a fork ourselves. Hopefully at some point in the future we can pick it back up again.

samjt commented 6 years ago

re-opening in case anyone wants to follow up

mathieudutour commented 6 years ago

The PRs have been merged, I'll help @lelandrichardson maintaining this repo, hopefully we can move it forward :)