search

lelandrichardson / react-primitives

Primitive React Interfaces Across Targets
MIT License
3.09k stars 108 forks source link

Fix React 16 for Web. #95

Closed dmiller9911 closed 6 years ago

dmiller9911 commented 6 years ago

React 16 support for react-native-web was added in v0.1.0. Update examples to use React 16. Added Touchable Example to allow easy verification of Touchable.

dmiller9911 commented 6 years ago

Missed the tests on this. Do I need to fix them or can I delete the /web folder along with react-web.js injection? They are no longer used since the switch to react-native-web. Fixing the tests will only require some dep upgrades and pulling over setValueForStyle from react-native-web.

geyang commented 6 years ago

@dmiller9911 from the looks of it some of the modules are either completely gone or moved.

ktj commented 6 years ago

It's easier to just make a simple package that imports stuff from rnw, rn, vr, sketchapp (using platform-specific extensions) and exports the same stuff as primitives does.

That's at least what I did

likethemammal commented 6 years ago

React 16.2 and react-native-web 0.2.2 support added with the build passing in this PR: https://github.com/lelandrichardson/react-primitives/pull/98

For anyone looking for a working npm package, checkout @likethemammal/react-primitives

dmiller9911 commented 6 years ago

closing since other PR's have been opened for this, and I am no longer using this package.