lelandrichardson / redux-pack

Sensible promise handling and middleware for redux
MIT License
1.33k stars 60 forks source link

Misleading ReadMe #72

Open rajatpharmeasy opened 5 years ago

rajatpharmeasy commented 5 years ago

"This can be problematic because we are treating several dispatches as all part of a single transaction, but in reality, each dispatch causes a separate rerender of the entire component tree, where we not only pay a huge performance penalty, but also risk the redux store being in an inconsistent state.

redux-pack helps prevent us from making these mistakes, as it doesn't give us the power of a dispatch function, but allows us to do all of the things we were doing before."

This statement builds a notion in my mind that by using this library, I will have less rerenders of the component tree, which is not true, in an async action atleast two rerenders will happen, once for loading state being set to true, another when loading is done and data is available.

Each dispatch doesn't cause rerenders, change in app state does, which happens in this library's case also.

Although I enjoy the less boilerplate, more simple and readable code made possible by this library, but I don't see how it optimizes the process.