lelandrichardson / redux-pack

Sensible promise handling and middleware for redux
MIT License
1.33k stars 60 forks source link

Update dependencies & npm scripts #74

Closed Robertmw closed 4 years ago

Robertmw commented 5 years ago
Robertmw commented 5 years ago

Hey, thanks for the review, I will make the changes today.

And sorry if I stress you or rush you, i don't mean to. I use this library in a project that is strict about dependency vulnerabilities (npm audit) hence the updated NPM package I made... And I cannot use the package as git dependency due to some project issues.

ljharb commented 5 years ago

@Robertmw in that case you can update the transitive dependencies in your lockfile using npm audit fix with no downstream changes required.

ljharb commented 5 years ago

Is npm test passing locally for you?

Robertmw commented 5 years ago

Fixed the npm test as well. I also added package-lock.json in .gitignore