Closed neoOpus closed 2 years ago
Thank you for PR. The new icon looks great, but:
gm4-polyfill.js
is removed, this script with not working on Greasemonkey (Firefox only).Thank you for PR. The new icon looks great, but:
- Changing the name and/or namespace will be create a new identity. This will prevent old users from receiving new updates.
- If
gm4-polyfill.js
is removed, this script with not working on Greasemonkey (Firefox only).In this script, https://github.com/lelinhtinh/Userscript/blob/b43dfc95a96e5fbb3bd2b292107d2f88fede4f16/image_viewer/Image_viewer.user.js#L34 will exclude non-image urls. Your change does not match image with no (or fake) extension. E.g.
- https://avatars.githubusercontent.com/u/5460915?v=4
- https://blogger.googleusercontent.com/img/b/R29vZ2xl/AVvXsEiG0_GZul3vSs58ctGC1cTPmLpG88aDHnoU2Tqwtbfm5liZaQiM4K2KnCHCK9uZehOgxcRviEl7Ezcuwov7uHvAZdCJITAGh-0SvXdwk__3Q32-qN4dSAqbL2WwL6d315Rkr84Z5REIBJ2_DNriRbqMsML3nIlxQ_aBBSqaEtBHPZsfykx4-Aif7R8qAA/
Ah I see, thanks for the detailed reply, I needed some answers... btw I am working on making this a bit better with some sort of zoom functionality using this lightweight library (https://fengyuanchen.github.io/viewerjs/), I found another extension that is using it but it conflicts with yours so I am trying to merge both of them into one... so let me know if I better create a new branch or I keep making changes and PR on this one? (I am not a programmer btw)
For the icon I will try to make a better one that is flatter and clearer on 16x16px, I don't know if a .ico or svg would work better in this case (so it displays the best one for each user)
You are right about the exclusion of non image files and I thought reversing that on the next updates (to have a uniform viewing experience of all image files) and I think just we have to keep it working on all URLs not just http*
For the
gm4-polyfill.js
it will download the js files even in browsers who don't need it? I mean if yes isn't better to create a separate version for GreaseMonkey?You can zoom the image by scrolling mouse wheel while holding CTRL key.
That's not the proper way to do it as it retain that zoom level and require using keyboard... I finished the mod btw and it is working properly
I hope this is fine, I renamed it after I found it confusing as I have another with the same name...