Add status icon to Character endpoint

lelouchB / final-space-api

Final Space API : RESTful API based on the show Final Space.

https://finalspaceapi.com

BSD 3-Clause "New" or "Revised" License

78 stars 47 forks source link

Add status icon to Character endpoint #115

Closed lelouchB closed 3 years ago

lelouchB commented 3 years ago

If we can send a character status icon, for example a green filled circle for a character that is alive.

It will save a lot of time for devs who are trying to show status using colored icons.

For example

For this we will have to create an icons (preferrably 50x50) jpeg. We only need three icons

Alive - Green Filled Circle
Dead/ Deceased - Red Filled Circle
Operational - Yellow Filled Circle

You can use any icon from web (free icon), or create one in paint. Just head over to paint and resize the area to 50x50px and create a circle, then fill it with proper color. Should be done in a few times..

Let me know if you have any question

ErickLemos commented 3 years ago

i can keep it

lelouchB commented 3 years ago

Hey @ErickLemos Can you also update the docs with issue.

Like the schema and example requests, etc. in character.md

ErickLemos commented 3 years ago

yes i can, i will do it! Something more?

lelouchB commented 3 years ago

yes i can, i will do it! Something more?

Not right now but if I think of something, will let you know.

Thanks

harsh599 commented 3 years ago

Hello @lelouchB I have been so near about achieving the results just need your help as my images are breaking dont know why I have kept my icons in img folder and accessing them as 'img/filename.jpg' but dont get the point as why images are breaking

It would be great if you can help!!

lelouchB commented 3 years ago

Hello @lelouchB I have been so near about achieving the results just need your help as my images are breaking dont know why I have kept my icons in img folder and accessing them as 'img/filename.jpg' but dont get the point as why images are breaking

It would be great if you can help!!

Hey @harsh599 No problem, I think know the problem but just to be sure can you send a PR with your code.

Thanks

harsh599 commented 3 years ago

Hello @lelouchB I have been so near about achieving the results just need your help as my images are breaking dont know why I have kept my icons in img folder and accessing them as 'img/filename.jpg' but dont get the point as why images are breaking It would be great if you can help!!

Hey @harsh599 No problem, I think know the problem but just to be sure can you send a PR with your code.

Thanks

Yes Sure Thankyou @lelouchB

harsh599 commented 3 years ago

Hey I am facing issue file comitting my changes I am stuck at point to push my content to repo its showing access denied issue

lelouchB commented 3 years ago

Hey @harsh599 I guess your repo is not updated with the latest commits, might wanna do that before pushing changes?

harsh599 commented 3 years ago

Hey @harsh599 I guess your repo is not updated with the latest commits, might wanna do that before pushing changes?

Hello @lelouchB I have made a PR request successfully kindly check it out.

lelouchB commented 3 years ago

@ErickLemos Any word on this?

ErickLemos commented 3 years ago

@ErickLemos Any word on this?

hello, sorry for the delay, I had some personal problems, I will return to the project tomorrow!

lelouchB commented 3 years ago

@ErickLemos Any word on this?

hello, sorry for the delay, I had some personal problems, I will return to the project tomorrow!

Yeah yeah No rush Take your time 👍

ErickLemos commented 3 years ago

I went back to the project, spent a few days out, sorry. did anyone work on this activity while I was away?

lelouchB commented 3 years ago

@harsh599 You up for this?

guzbarraf commented 3 years ago

Hi @lelouchB is this issue still available?

lelouchB commented 3 years ago

@guzbarraf Yes I will assign it you

guzbarraf commented 3 years ago

thanks @lelouchB, tomorrow I'll upload the PR