search

lelouchB / final-space-api

Final Space API : RESTful API based on the show Final Space.
https://finalspaceapi.com
BSD 3-Clause "New" or "Revised" License
78 stars 47 forks source link

Updates greetings workflow #116

Closed DmnChzl closed 3 years ago

DmnChzl commented 3 years ago

Here are two personalized messages for the first new issue and the first pull request per user. These messages come from Gary Goodspeed (Final Space's season 1). More information here 👉 https://github.com/lelouchB/final-space-api/issues/107

lelouchB commented 3 years ago

Hey Hey I never got any reply to the comment, I though it must have got lost in the notifications so I asked for an update..

Looks good to me Just resolve that conversation and I will proceed to merge this.

Thanks

DmnChzl commented 3 years ago

Hey @lelouchB 👋 No problem! If it's good for you, it's good for me 😉

lelouchB commented 3 years ago

Again I wanted to just ask what github.actor will do?

I asked it 3 days ago.😁😊

DmnChzl commented 3 years ago

Indeed... Notifications hell! 😅 ${{ github.actor }} is a github's tip, to display the user's login in a notification. For example, to me, this should display:

That's Not A Cookie. And You Know That @MrDoomy, You Know That!