Added 404 Page

[Skr-suyash]

Added the 404 page. Go to baseURL/404" to see it. Check if it is working. 😄😅

[lelouchB]

Added the 404 page. Go to baseURL/404" to see it. Check if it is working. 😄😅

You haven't checked? Also what about other routes that doesn't exist?

[Skr-suyash]

Checked. But the problem is that Docasaurus has no support for redirecting other routes to 404. Should I use React Router. Please check once yourself if it is working. Only baseURL/404 is supported (in GitHub page)

[lelouchB]

Great 👍 I will get to it first thing in the morning.

No need for React router. This is fine,

Thanks for your work on this.

On Fri, Oct 9, 2020, 10:06 PM Suyash Kumar notifications@github.com wrote:

You haven't checked? Also what about other routes that doesn't exist? Checked. But the problem is that Docasaurus has no support for redirecting other routes to 404. Should I use React Router. Please check once yourself if it is working.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/lelouchB/final-space-api/pull/118#issuecomment-706283024, or unsubscribe https://github.com/notifications/unsubscribe-auth/AK52CAT3255IKD2WWEQ37BDSJ43ZTANCNFSM4SKJDHVQ .

[Skr-suyash]

Hey, is this okay. 😁

[lelouchB]

Hey, is this okay. 😁

Still going through previous PRs, will get to this in a few hours.

Thanks for your patience

[lelouchB]

Hey @Skr-suyash This looks great, I checked it The problem is after npm run build, if we use npm run serve to serve the build folder, all the bad routes are automatically handled by Docusaurus Here is the page for http://localhost:3000/5

But the same is not seen after the build folder is deployed with express.

This has become more for a investigation issue. Thanks for your work