search

lelouchB / final-space-api

Final Space API : RESTful API based on the show Final Space.
https://finalspaceapi.com
BSD 3-Clause "New" or "Revised" License
78 stars 47 forks source link

Status icon to characters #121

Closed harsh599 closed 3 years ago

harsh599 commented 3 years ago

Hello @lelouchB I request you to kindly look into the problem as why my status images are breaking in FrontEnd side I am sure there must be something issue related to their access and the path of the images. Looking forward to contribute more

lelouchB commented 3 years ago

Hey @harsh599 Have you tried using useBaseUrl() See this https://github.com/harsh599/final-space-api/blob/96b042e790d3454ebc9dad646ea5fdb81b914185/frontend/src/pages/Components/Body/_Card.js#L12 Also, there is no need for updating the status on the frontend now.

The issue was for adding it to the schema so it is included in the response and user don't have to check the status manually. Once it has been updated on the backend, this change on the frontend will be much easier to incorporate.

If you want, you can send the status images to backend/images/status folder, so I can add it to the database. Or atleast I will approve it.

Let me know if you have any other questions.

Hope this answer your question.

harsh599 commented 3 years ago

Hey @harsh599 Have you tried using useBaseUrl() See this https://github.com/harsh599/final-space-api/blob/96b042e790d3454ebc9dad646ea5fdb81b914185/frontend/src/pages/Components/Body/_Card.js#L12 Also, there is no need for updating the status on the frontend now.

The issue was for adding it to the schema so it is included in the response and user don't have to check the status manually. Once it has been updated on the backend, this change on the frontend will be much easier to incorporate.

If you want, you can send the status images to backend/images/status folder, so I can add it to the database. Or atleast I will approve it.

Let me know if you have any other questions.

Hope this answer your question.

The Issue has been fixed now I think I have been accessing the image in a wrong way image

I have also added the images in the backend/images/status folder you can make the Back End Related changes.Thankyou Brother

lelouchB commented 3 years ago

Hey @harsh599 Awesome 👍 I will approve this PR but will have to wait for @ErickLemos to finish since he was first to take up the issue and it is assigned to him.

Great Work

harsh599 commented 3 years ago

Hello @lelouchB I have made some improvisations in the code for a better flexibility for you.

harsh599 commented 3 years ago

Hey @harsh599 Awesome 👍 I will approve this PR but will have to wait for @ErickLemos to finish since he was first to take up the issue and it is assigned to him.

Great Work

Oh Thankyou

ErickLemos commented 3 years ago

@lelouchB no problem, you can accept the PR and assign the task to it!

lelouchB commented 3 years ago

@lelouchB no problem, you can accept the PR and assign the task to it!

Just to be sure You are saying to reassign the issue Right?

ErickLemos commented 3 years ago

Yeah!