search

lelouchB / final-space-api

Final Space API : RESTful API based on the show Final Space.
https://finalspaceapi.com
BSD 3-Clause "New" or "Revised" License
78 stars 47 forks source link

Highlight import lines in Example pages #136

Closed lelouchB closed 3 years ago

lelouchB commented 3 years ago

Highlight important lines in the code snippets in Examples.

For example in the frontend/docs/react.mdx, you can highlight the useEffect() and axios fetching code lines.

Resource https://v2.docusaurus.io/docs/markdown-features/#line-highlighting

P.S just highlight the few important lines like where data is fetched, used, etc.

lelouchB commented 3 years ago

Assigned to @bgildson

bgildson commented 3 years ago

Hey @lelouchB, could I take this one?

lelouchB commented 3 years ago

Done ✔

lelouchB commented 3 years ago

Hey @bgildson Any update on this?

bgildson commented 3 years ago

I have added highlight to the frontend/docs/react.mdx in the main code snippets pieces on #137

lelouchB commented 3 years ago

I have added highlight to the frontend/docs/react.mdx in the main code snippets pieces on #137

Yes, I saw that Great work 👍

But as said in my review, the issue is for all the examples and not just one. So, please update other examples too.

Thanks