search

lelouchB / final-space-api

Final Space API : RESTful API based on the show Final Space.
https://finalspaceapi.com
BSD 3-Clause "New" or "Revised" License
78 stars 47 forks source link

Quotes Endpoint #140

Closed lelouchB closed 3 years ago

lelouchB commented 3 years ago

What is this ./endpoint about ? Final Space has some great fun quotes by its characters. This endpoint will be sending quotes.

Maybe after initial setup add a filter that will send quotes from a specific character.

What is the schema ?

quote : 'Quote',
by : 'Name of character',
character : 'URL to that character endpoint',
image: 'URL to Character Image'
Mayank0255 commented 3 years ago

@lelouchB could I try this one?

P.S. - I am new to Open Source Contribution, but, I am not new to web development with React, Node.js and MongoDB

lelouchB commented 3 years ago

@Mayank0255 Ofcourse This is the endpoint suggestion issue of Quotes endpoint

Can you comment on #141 so I can assign it to you

Thanks

Mayank0255 commented 3 years ago

@lelouchB sure will do that right away and kindly explain it to me a little that you want this endpoint to be built with our imagination right? You have provided us what it should do and a brief about the schema

lelouchB commented 3 years ago

@lelouchB sure will do that right away and kindly explain it to me a little that you want this endpoint to be built with our imagination right? You have provided us what it should do and a brief about the schema

Answered here https://github.com/lelouchB/final-space-api/issues/141#issuecomment-728718700

Mayank0255 commented 3 years ago

@lelouchB

After you would have added the quotes data to the database, could you provide me with the .env file as or else to test out the endpoints I would have to add some data of my own

lelouchB commented 3 years ago

@lelouchB

After you would have added the quotes data to the database, could you provide me with the .env file as or else to test out the endpoints I would have to add some data of my own

Are you talking about testing quotes endpoint or all endpoints in general ?

Mayank0255 commented 3 years ago

Are you talking about testing quotes endpoint or all endpoints in general ?

@lelouchB Ya I'm talking about that only

lelouchB commented 3 years ago

For active endpoints you can run npm run seed in the backend directory which will fill your local MongoDB collection with data from API You can manually add quotes to that collection for local development.

Refer here. https://github.com/lelouchB/final-space-api/blob/4a0b007ce782c45db877882aee560240916af7a9/backend/package.json#L13

Mayank0255 commented 3 years ago

Cool got it

lelouchB commented 3 years ago

@Mayank0255 Quotes endpoint is live.

Thanks to your contribution, I was able to ship it into production.

https://finalspaceapi.com/blog/quote https://finalspaceapi.com/api/v0/quote

Mayank0255 commented 3 years ago

@lelouchB

Thanks a lot Ashutosh and the mention on the blog also means a lot.

Looking forward to work with you in future as well.

lelouchB commented 3 years ago

NP 👍 If you want you can also create an example for this endpoint under the Examples section https://github.com/lelouchB/final-space-api/issues/32

Thanks :)

Mayank0255 commented 3 years ago

NP 👍 If you want you can also create an example for this endpoint under the Examples section

32

Thanks :)

Not at the moment but will ping you later on if I get time for it