lelouchB / final-space-api

Final Space API : RESTful API based on the show Final Space.
https://finalspaceapi.com
BSD 3-Clause "New" or "Revised" License
78 stars 47 forks source link

Create route for Quotes Endpoint #143

Closed lelouchB closed 3 years ago

lelouchB commented 3 years ago

140

To Do

Mayank0255 commented 3 years ago

@lelouchB What's the difference between the two issues?

lelouchB commented 3 years ago

@lelouchB What's the difference between the two issues?

That is the global issue around this whole endpoint.

This is a specific issue.

After this is done. I will create issues for documentation.

Can I assign this to you?

Mayank0255 commented 3 years ago

Sure no issues

Mayank0255 commented 3 years ago

@lelouchB What routes do you need me to add?

Just GET all quotes?

lelouchB commented 3 years ago

@lelouchB What routes do you need me to add?

Just GET all quotes?

Yes for now GET all quotes is fine. I am also thinking of adding a filter of name in this endpoint where users can give a query something like /api/v0/quote/gary or /api/v0/quote?by=gary_goodspeed. Just a thought.

But yeah, for now GET all is perfect. Also add the sort and limit config as added in other endpoints.

Mayank0255 commented 3 years ago

@lelouchB

Cool would do all that and ping me after this issue when you think of implementing the filtering thing and other routes

lelouchB commented 3 years ago

Of course Will do so.

Mayank0255 commented 3 years ago

Where to write the test for the route? And I have to write the docs for quotes as well write?

lelouchB commented 3 years ago

There are no tests as of now. It is under development by @JuanVqz

It's your choice, you can write the docs or just work on the code. I will either create an issue and assign someone for the documentation or write them myself.

Mayank0255 commented 3 years ago

Okay then will just create a PR