Examples button on Homepage points to redundant route.

[lelouchB]

[lelouchB]

Its simple enough, the Examples button on homepage should point to https://finalspaceapi.com/docs/examples/react/

It would not even require you to set up the project.

I'll assign this to you.

Let me know if you have any questions.

[ranjithjupaka]

Tq sir Sent from Mail for Windows From: ASHUTOSH KUMAR SINGHSent: 16 August 2021 19:51To: lelouchB/final-space-apiCc: Ranjith jupaka; MentionSubject: Re: [lelouchB/final-space-api] Examples button on Homepage points to redundant route. (#157) Hey @ranjithjupakaSureIts simple enough, the Examples button on homepage should point to https://finalspaceapi.com/docs/examples/react/It would not even require you to set up the project.I'll assign this to you.Let me know if you have any questions.—You are receiving this because you were mentioned.Reply to this email directly, view it on GitHub, or unsubscribe. 

[ranjithjupaka]

ok sir

[ranjithjupaka]

hello, sir I understood what is the bug is! I will soon fix it thank you, but I did not understand what do you mean by you would not even require you to set up the project

[lelouchB]

Its pointing to https://finalspaceapi.com/docs/react/ but it should point to https://finalspaceapi.com/docs/examples/react/

The above image is the error.

On Tue, Aug 17, 2021, 8:44 AM Ranjith jupaka @.***> wrote:

hello, sir I am a bit confused regarding the bug actually I was literally breaking my head to understand the bug. finally what I understood was presently the Examples button on the homepage is pointing to https://finalspaceapi.com/docs/examples/react/ but it should point to https://finalspaceapi.com/docs/react/ (as seen from the above image)

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/lelouchB/final-space-api/issues/157#issuecomment-899961328, or unsubscribe https://github.com/notifications/unsubscribe-auth/AK52CAVTW3QKN5HCMMGUYMDT5HHZ7ANCNFSM5CHY6VVA .

[ranjithjupaka]

ha understood sir thank you how can i fix that without set up??

[lelouchB]

hello, sir I understood what is the bug is! I will soon fix it thank you, but I did not understand what do you mean by you would not even require you to set up the project

I meant that since the change is only a couple of lines, it's not specifically needed to install the project on your local machine.

This file needs to be edited https://github.com/lelouchB/final-space-api/blob/main/frontend/src/pages/Components/Body/_InfoCointainer.js

You can just edit it in the GitHub itself

[ranjithjupaka]

ok sir I will do it now

[lelouchB]

Also, no need for Sir

Even when contributing to large codebases of Mozilla, MediaWiki, etc,
Project maintainers and other contributors prefer if you call them with their names.

So, just Ashutosh is fine :)