search

lelutin / puppet-fail2ban

Manage fail2ban and its jails with puppet
GNU General Public License v3.0
8 stars 31 forks source link

$logpath param now allows passing array or string #48

Closed jkroepke closed 2 years ago

jkroepke commented 2 years ago

Credits to https://github.com/calmenergy/calmenergy-fail2ban/pull/4

Since there are no tests here, I test this on my own local setup.

lelutin commented 2 years ago

Oh that's an important change! I apparently had not seen that logpath can contain more than one value. thanks for the PR :100:

I'll take some time to review and test the changes tonight.

in the absolute, I'd prefer having only one type for the parameter, e.g. an array of strings, but permitting both plain string and array of strings seems like a better first step.

I'll update again as soon as I've managed to review the changes.

lelutin commented 2 years ago

looks good and works as expected. thanks!

jkroepke commented 2 years ago

It would be great, if you could publish this to forge.

lelutin commented 2 years ago

you're right. it's currently the only relevant change on top of the latest release but it's already been a while so I might as well make a new release with this.

I'll try and do it tomorrow!